Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Priest baseline presets cleanup #19

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Priest baseline presets cleanup #19

merged 2 commits into from
Nov 24, 2024

Conversation

ericbtaylorjr
Copy link
Contributor

No description provided.

@ericbtaylorjr
Copy link
Contributor Author

ericbtaylorjr commented Nov 24, 2024 •
edited
Loading

Still learning how all this works, could use some eyes. Working on tests now. After these are done, someone will still have to go through and rip out all the SoD stuff, ensure calculations are not impacted by SoD changes, etc. But hopefully this cleans things up a bit.

@ericbtaylorjr ericbtaylorjr marked this pull request as ready for review November 24, 2024 02:31
@ericbtaylorjr ericbtaylorjr self-assigned this Nov 24, 2024
sanguinerarogue
sanguinerarogue approved these changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@sanguinerarogue sanguinerarogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same , looks good.

@sanguinerarogue sanguinerarogue merged commit 84a1a50 into master Nov 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanguinerarogue sanguinerarogue sanguinerarogue approved these changes

Assignees

@ericbtaylorjr ericbtaylorjr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericbtaylorjr @sanguinerarogue