Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mage baseline presets cleanup #23

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

ericbtaylorjr
Copy link
Contributor

No description provided.

Copy link
Contributor

@sanguinerarogue sanguinerarogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phase 1 Mage is Frost, Phase 2 is primarily Frost and Phase 3 + is fire. There is a chance with duel spec meta that fire gets played on non-fire immune bosses in MC/BWL. Might be worth setting up Frost/Fire tests off the rip?

@ericbtaylorjr
Copy link
Contributor Author

ericbtaylorjr commented Nov 25, 2024

Phase 1 Mage is Frost, Phase 2 is primarily Frost and Phase 3 + is fire. There is a chance with duel spec meta that fire gets played on non-fire immune bosses in MC/BWL. Might be worth setting up Frost/Fire tests off the rip?

I think this probably makes sense to just do as part of the preset changes which need to follow (proper gear, talents, apl + preset creation). I'd like to have at least one preset per class for every phase and a corresponding test for every preset to ensure true, confident coverage and it's maintained without the need to update for different phases. And given we'll have to update those tests once the presets are changed, might as well just baseline it here and then update for whatever applicable coverage is desired when doing the preset follow-up work.

@ericbtaylorjr ericbtaylorjr dismissed sanguinerarogue’s stale review November 25, 2024 20:28

Talked in Disc about doing this as part of the follow-up preset work

@sanguinerarogue sanguinerarogue merged commit 4eca450 into master Nov 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants