-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass at warrior #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanguinerarogue
requested review from
ericbtaylorjr,
kayla-glick,
TheBackstabi and
TheGroxEmpire
December 8, 2024 19:28
TheGroxEmpire
previously requested changes
Dec 8, 2024
Tested vs guybrush today as baseline comparision. +20 dps in most the scenarios I ran with orc prebis. Looked like wowsims giving +1-2 hoj procs per fight rest was within 1-5 dps for abilities. Not convinced anything is wrong |
Issues with sunder armor threat with might set and wrath rage reduction (slice not ever checking correctly?) if anyone wants to take a look |
TheBackstabi
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Questions/To Do:
Not a warrior player so would appreciate a thorough look through. I will work on the items and item sets in the mean time.