Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at warrior #39

Merged
merged 12 commits into from
Dec 23, 2024
Merged

First pass at warrior #39

merged 12 commits into from
Dec 23, 2024

Conversation

sanguinerarogue
Copy link
Contributor

Questions/To Do:

  • Bloodrge Damage Taken
  • Bloodthirst Heal
  • Deep Wounds Questions - currently its properly refreshing, do I need to do check if the damage > previous dot to overwrite or is that automatic?
  • Revenge pre-SoD Cooldown - it shouldnt have a cooldown at all right?
  • Shield Slam Threat - need some confirmation on values since I think there was some SoD auras adjusting it
  • Slam - Flat threat bonus (comment in code)
  • Booming Voice - think the aura was just a cost modification but wasnt sure if anything else was included.

Not a warrior player so would appreciate a thorough look through. I will work on the items and item sets in the mean time.

@sanguinerarogue sanguinerarogue marked this pull request as ready for review December 8, 2024 19:28
sim/warrior/deep_wounds.go Outdated Show resolved Hide resolved
sim/warrior/deep_wounds.go Outdated Show resolved Hide resolved
sim/warrior/revenge.go Show resolved Hide resolved
@sanguinerarogue
Copy link
Contributor Author

Tested vs guybrush today as baseline comparision. +20 dps in most the scenarios I ran with orc prebis. Looked like wowsims giving +1-2 hoj procs per fight rest was within 1-5 dps for abilities. Not convinced anything is wrong

@sanguinerarogue
Copy link
Contributor Author

Issues with sunder armor threat with might set and wrath rage reduction (slice not ever checking correctly?) if anyone wants to take a look

@sanguinerarogue sanguinerarogue merged commit 4178576 into master Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants