Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudkeepers + P2 PvP #59

Merged
merged 1 commit into from
Dec 29, 2024
+63 −2
Merged

Cloudkeepers + P2 PvP #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sim/common/vanilla/item_effects.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ const (
EbonHiltOfMarduk = 14576
FrightskullShaft = 14531
BarovianFamilySword = 14541
CloudkeeperLegplates = 14554
Frightalon = 14024
// HeadmastersCharge = 13937
GravestoneWarAxe = 13983
Expand Down Expand Up @@ -2668,6 +2669,10 @@ func init() {
BlazefuryTriggerAura(character, 7712, core.SpellSchoolFire, 2)
})

// https://www.wowhead.com/classic/item=14554/cloudkeeper-legplates
// Use: Increases Attack Power by 100 for 30 sec. (15 Min Cooldown)
core.NewSimpleStatOffensiveTrinketEffect(CloudkeeperLegplates, stats.Stats{stats.AttackPower: 100, stats.RangedAttackPower: 100}, time.Second*30, time.Minute*15)

// https://www.wowhead.com/classic/item=1168/skullflame-shield
// Equip: When struck in combat has a 3% chance of stealing 35 life from target enemy. (Proc chance: 3%)
// Equip: When struck in combat has a 1% chance of dealing 75 to 125 Fire damage to all targets around you. (Proc chance: 1%)
Expand Down
14 changes: 14 additions & 0 deletions sim/rogue/dps_rogue/TestCombatDaggers.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,13 @@ dps_results: {
tps: 771.0513
}
}
dps_results: {
key: "TestCombatDaggers-Phase5-AllItems-Champion'sVestments"
value: {
dps: 896.12446
tps: 636.24837
}
}
dps_results: {
key: "TestCombatDaggers-Phase5-AllItems-DarkmantleArmor"
value: {
Expand All @@ -124,6 +131,13 @@ dps_results: {
tps: 720.19773
}
}
dps_results: {
key: "TestCombatDaggers-Phase5-AllItems-LieutenantCommander'sVestments"
value: {
dps: 896.12446
tps: 636.24837
}
}
dps_results: {
key: "TestCombatDaggers-Phase5-AllItems-Madcap'sOutfit"
value: {
Expand Down
14 changes: 14 additions & 0 deletions sim/rogue/dps_rogue/TestCombatSinisterStrike.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,13 @@ dps_results: {
tps: 814.19968
}
}
dps_results: {
key: "TestCombatSinisterStrike-Phase5-AllItems-Champion'sVestments"
value: {
dps: 919.47147
tps: 652.82474
}
}
dps_results: {
key: "TestCombatSinisterStrike-Phase5-AllItems-DarkmantleArmor"
value: {
Expand All @@ -124,6 +131,13 @@ dps_results: {
tps: 761.1862
}
}
dps_results: {
key: "TestCombatSinisterStrike-Phase5-AllItems-LieutenantCommander'sVestments"
value: {
dps: 919.47147
tps: 652.82474
}
}
dps_results: {
key: "TestCombatSinisterStrike-Phase5-AllItems-Madcap'sOutfit"
value: {
Expand Down
2 changes: 1 addition & 1 deletion sim/rogue/_items_sets_pvp.go → sim/rogue/items_sets_pvp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
)

///////////////////////////////////////////////////////////////////////////
// SoD Phase 4 Item Sets
// Classic Phase 2
///////////////////////////////////////////////////////////////////////////

var ItemSetChampionsVestments = core.NewItemSet(core.ItemSet{
Expand Down
14 changes: 14 additions & 0 deletions sim/warrior/dps_warrior/TestP1DPSWarrior.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,13 @@ dps_results: {
tps: 1033.50286
}
}
dps_results: {
key: "TestP1DPSWarrior-Phase1-AllItems-Champion'sBattlegear"
value: {
dps: 1197.18775
tps: 1047.39886
}
}
dps_results: {
key: "TestP1DPSWarrior-Phase1-AllItems-Conqueror'sBattlegear"
value: {
Expand All @@ -131,6 +138,13 @@ dps_results: {
tps: 1111.46724
}
}
dps_results: {
key: "TestP1DPSWarrior-Phase1-AllItems-LieutenantCommander'sBattlegear"
value: {
dps: 1197.18775
tps: 1047.39886
}
}
dps_results: {
key: "TestP1DPSWarrior-Phase1-AllItems-Vindicator'sBattlegear"
value: {
Expand Down
2 changes: 1 addition & 1 deletion sim/warrior/_item_sets_pvp.go → sim/warrior/item_sets_pvp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
)

///////////////////////////////////////////////////////////////////////////
// SoD Phase 4 Item Sets
// Classic Phase 2
///////////////////////////////////////////////////////////////////////////

var ItemSetChampionsBattlegear = core.NewItemSet(core.ItemSet{
Expand Down
14 changes: 14 additions & 0 deletions sim/warrior/tank_warrior/TestP1TankWarrior.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,13 @@ dps_results: {
tps: 324.94163
}
}
dps_results: {
key: "TestP1TankWarrior-Phase1-AllItems-Champion'sBattlegear"
value: {
dps: 176.5019
tps: 326.39273
}
}
dps_results: {
key: "TestP1TankWarrior-Phase1-AllItems-Conqueror'sBattlegear"
value: {
Expand All @@ -131,6 +138,13 @@ dps_results: {
tps: 335.07122
}
}
dps_results: {
key: "TestP1TankWarrior-Phase1-AllItems-LieutenantCommander'sBattlegear"
value: {
dps: 176.5019
tps: 326.39273
}
}
dps_results: {
key: "TestP1TankWarrior-Phase1-AllItems-Vindicator'sBattlegear"
value: {
Expand Down
Loading