Classic Shaman. Launching just Ele for now #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kayla-glick
commented
Dec 31, 2024
•
kayla-glick
commented
- Updated items and tier sets for Shamans
- Updated Stormstrike debuff and added some configuration for it to customize how often it's used and other attackers consuming charges
- Added presets for phases 1-6 for Ele as well as default settings for Phase 2
- Still need to verify some things for Enhancement
kayla-glick
commented
Jan 13, 2025
| @@ -33,44 +33,44 @@ var EnchantOverrides = []*proto.UIEnchant{ | |||
| {EffectId: 1510, ItemId: 11649, SpellId: 15406, Name: "Lesser Arcanum of Voracity", Quality: proto.ItemQuality_ItemQualityUncommon, Stats: stats.Stats{stats.Spirit: 8}.ToFloatArray(), Type: proto.ItemType_ItemTypeHead, ExtraTypes: []proto.ItemType{proto.ItemType_ItemTypeLegs}, EnchantType: proto.EnchantType_EnchantTypeKit}, | |||
|
|
|||
| // Drop in Dire Maul | |||
| {EffectId: 2544, ItemId: 18330, SpellId: 22844, Name: "Arcanum of Focus", Quality: proto.ItemQuality_ItemQualityUncommon, Stats: stats.Stats{stats.SpellPower: 8}.ToFloatArray(), Type: proto.ItemType_ItemTypeHead, ExtraTypes: []proto.ItemType{proto.ItemType_ItemTypeLegs}, EnchantType: proto.EnchantType_EnchantTypeKit}, | |||
There was a problem hiding this comment.
Added phases to dire maul, MC, AQ, and Naxx enchants
kayla-glick
commented
Jan 13, 2025
| {EffectId: 2715, ItemId: 23547, SpellId: 29475, Name: "Resilience of the Scourge", Quality: proto.ItemQuality_ItemQualityEpic, Stats: stats.Stats{stats.HealingPower: 31, stats.MP5: 5}.ToFloatArray(), Type: proto.ItemType_ItemTypeShoulder, Phase: 6}, | ||
| {EffectId: 2717, ItemId: 23548, SpellId: 29483, Name: "Might of the Scourge", Quality: proto.ItemQuality_ItemQualityEpic, Stats: stats.Stats{stats.AttackPower: 26, stats.MeleeCrit: 0.01}.ToFloatArray(), Type: proto.ItemType_ItemTypeShoulder, Phase: 6}, | ||
| {EffectId: 2716, ItemId: 23549, SpellId: 29480, Name: "Fortitude of the Scourge", Quality: proto.ItemQuality_ItemQualityEpic, Stats: stats.Stats{stats.Stamina: 16, stats.BonusArmor: 100}.ToFloatArray(), Type: proto.ItemType_ItemTypeShoulder, Phase: 6}, | ||
| {EffectId: 2721, ItemId: 23545, SpellId: 29467, Name: "Power of the Scourge", Quality: proto.ItemQuality_ItemQualityEpic, Stats: stats.Stats{stats.SpellPower: 15, stats.SpellCrit: 1 * core.SpellCritRatingPerCritChance}.ToFloatArray(), Type: proto.ItemType_ItemTypeShoulder, Phase: 6}, |
There was a problem hiding this comment.
Fixed the stats on this one. Not sure why it was 0.01
kayla-glick
commented
Jan 13, 2025
| @@ -1061,7 +1061,7 @@ export const specToEligibleRaces: Record<Spec, Array<Race>> = { | |||
|
|
|||
| // Specs that can dual wield. This could be based on class, except that | |||
| // Enhancement Shaman learn dual wield from a talent. | |||
| const dualWieldClasses: Array<Class> = [Class.ClassHunter, Class.ClassRogue, Class.ClassShaman, Class.ClassWarrior]; | |||
There was a problem hiding this comment.
Shamans can't dual wield in classic
kayla-glick
commented
Jan 13, 2025
| @@ -1520,28 +1520,13 @@ export function getEligibleItemSlots(item: Item): Array<ItemSlot> { | |||
| throw new Error('Could not find item slots for item: ' + Item.toJsonString(item)); | |||
| } | |||
|
|
|||
| // Returns whether the given main-hand and off-hand items can be worn at the | |||
| // same time. | |||
| export function validWeaponCombo(mainHand: Item | null | undefined, offHand: Item | null | undefined, canDW2h: boolean): boolean { | |||
There was a problem hiding this comment.
Removed all of the logic around Titan's Grip because it doesn't apply
kayla-glick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.