New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass at handedness crit cap for Classic #75

Merged

sanguinerarogue merged 3 commits into master from WeaponSkillUI

Jan 11, 2025

Contributor

sanguinerarogue commented Jan 8, 2025

No description provided.


          First pass at handedness crit cap for Classic

e39088a

sanguinerarogue requested a review from kayla-glick

January 8, 2025 20:23

Contributor Author

sanguinerarogue commented Jan 8, 2025 •

edited

Loading

To Do:

Hide offhand with 2H weapons once UI is decided upon
Add handedness to weapon skill/hit UI
Clean up 2h vs 1h weapon skill in the hit UI
Make UI actually look good


          updates

40bfeda

sanguinerarogue requested review from ericbtaylorjr and TheBackstabi

January 10, 2025 17:40

TheBackstabi approved these changes

View reviewed changes

Contributor

TheBackstabi left a comment

i didn't read send it

1337LutZ reviewed

View reviewed changes

ui/core/components/character_stats.tsx Outdated Show resolved Hide resolved

1337LutZ reviewed

View reviewed changes

ui/core/player.ts Show resolved Hide resolved

1337LutZ reviewed

View reviewed changes

ui/core/player.ts Outdated Show resolved Hide resolved

1337LutZ reviewed

View reviewed changes

ui/core/player.ts Outdated Show resolved Hide resolved

1337LutZ reviewed

View reviewed changes

ui/core/player.ts Outdated Show resolved Hide resolved

1337LutZ reviewed

View reviewed changes

ui/core/player.ts Show resolved Hide resolved


          adjusts to level scaling

ff7897b

sanguinerarogue merged commit 502fa7d into master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet