Skip to content

Commit

Permalink
Merge pull request #15 from wowsims/spark-of-inspiration-buff
Browse files Browse the repository at this point in the history
Add Spark of Inspiration buff
  • Loading branch information
kayla-glick authored Feb 2, 2024
2 parents cbc97c2 + 5352ee4 commit 0830ba5
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 0 deletions.
2 changes: 2 additions & 0 deletions proto/common.proto
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,7 @@ message PartyBuffs {
}

// These are usually individual actions taken by other Characters.
// NextIndex: 18
message IndividualBuffs {
bool blessing_of_kings = 1;
TristateEffect blessing_of_wisdom = 2;
Expand All @@ -474,6 +475,7 @@ message IndividualBuffs {
// New SoD Buffs
bool boon_of_blackfathom = 15;
bool ashenvale_pvp_buff = 16;
bool spark_of_inspiration = 17;
}

message Consumes {
Expand Down
7 changes: 7 additions & 0 deletions sim/core/buffs.go
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,13 @@ func applyBuffEffects(agent Agent, raidBuffs *proto.RaidBuffs, partyBuffs *proto
}

// SoD World Buffs
if individualBuffs.SparkOfInspiration {
character.AddStat(stats.SpellCrit, 4*CritRatingPerCritChance)
character.AddStat(stats.SpellPower, 42)
character.PseudoStats.MeleeSpeedMultiplier *= 1.1
character.PseudoStats.RangedSpeedMultiplier *= 1.1
}

if individualBuffs.BoonOfBlackfathom {
character.AddStat(stats.MeleeCrit, 2*CritRatingPerCritChance)
// TODO: character.AddStat(stats.RangedCrit, 2 * CritRatingPerCritChance)
Expand Down
13 changes: 13 additions & 0 deletions ui/core/components/inputs/buffs_debuffs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,14 @@ export const AshenvalePvpBuff = withLabel(
'Ashenvale PvP Buff',
);

export const SparkOfInspiration = withLabel(
makeBooleanIndividualBuffInput({
actionId: () => ActionId.fromSpellId(438536),
fieldName: 'sparkOfInspiration',
}),
'Spark of Inspiration',
)

///////////////////////////////////////////////////////////////////////////
// DEBUFFS
///////////////////////////////////////////////////////////////////////////
Expand Down Expand Up @@ -857,6 +865,11 @@ export const RAID_BUFFS_CONFIG = [
] as PickerStatOptions[]

export const WORLD_BUFFS_CONFIG = [
{
config: SparkOfInspiration,
picker: IconPicker,
stats: [Stat.StatSpellPower, Stat.StatMeleeHaste, Stat.StatRangedAttackPower],
},
{
config: BoonOfBlackfathom,
picker: IconPicker,
Expand Down

0 comments on commit 0830ba5

Please sign in to comment.