Skip to content

Commit

Permalink
Merge pull request #864 from adocoD/Cobraslredo
Browse files Browse the repository at this point in the history
Fixing the accidental Cobra Slayer removal
  • Loading branch information
kayla-glick authored Jul 5, 2024
2 parents 9e2ded6 + 6fbc6c8 commit 1b13a4d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions assets/database/db.json
Original file line number Diff line number Diff line change
Expand Up @@ -9917,6 +9917,7 @@
{"id":453622,"name":"Engrave Ring - Feral Combat Specialization","icon":"ability_druid_catformattack","type":11,"requiresLevel":1,"classAllowlist":[1]},
{"id":458287,"name":"Engrave Chest - Hallowed Ground","icon":"spell_holy_crusade","type":5,"requiresLevel":1,"classAllowlist":[4]},
{"id":458318,"name":"Engrave Belt - Malleable Protection","icon":"spell_holy_restoration","type":8,"requiresLevel":1,"classAllowlist":[4]},
{"id":458393,"name":"Engrave Chest - Cobra Slayer","icon":"spell_nature_guardianward","type":5,"classAllowlist":[2]},
{"id":458479,"name":"Engrave Boots - Wyvern Strike","icon":"inv_spear_02","type":10,"requiresLevel":1,"classAllowlist":[2]},
{"id":458856,"name":"Engrave Cloak - Divine Light","icon":"spell_holy_surgeoflight","type":4,"requiresLevel":1,"classAllowlist":[4]},
{"id":459312,"name":"Engrave Ring - Defense Specialization","icon":"inv_shield_06","type":11,"requiresLevel":1,"classAllowlist":[0,9,4,6,7,8,1]},
Expand Down Expand Up @@ -14086,6 +14087,7 @@
{"id":409554,"name":"Explosive Shot","icon":"ability_hunter_explosiveshot","requiresLevel":1,"hasBuff":true},
{"id":409580,"name":"Heart of the Lion","icon":"ability_hunter_pet_cat","requiresLevel":1,"hasBuff":true},
{"id":409583,"name":"Heart of the Lion","icon":"ability_hunter_pet_cat","requiresLevel":1,"hasBuff":true},
{"id":409593,"name":"Kill Shot","icon":"ability_hunter_assassinate2","requiresLevel":1},
{"id":409691,"name":"Raptor Strike","icon":"ability_meleedamage","requiresLevel":1},
{"id":409693,"name":"Raptor Strike","icon":"ability_meleedamage","requiresLevel":8},
{"id":409748,"name":"Raptor Strike","icon":"ability_meleedamage","requiresLevel":16},
Expand Down
1 change: 1 addition & 0 deletions assets/database/leftover_db.json
Original file line number Diff line number Diff line change
Expand Up @@ -1857,6 +1857,7 @@
{"id":453622,"name":"Engrave Ring - Feral Combat Specialization","icon":"ability_druid_catformattack","type":11,"requiresLevel":1,"classAllowlist":[1]},
{"id":458287,"name":"Engrave Chest - Hallowed Ground","icon":"spell_holy_crusade","type":5,"requiresLevel":1,"classAllowlist":[4]},
{"id":458318,"name":"Engrave Belt - Malleable Protection","icon":"spell_holy_restoration","type":8,"requiresLevel":1,"classAllowlist":[4]},
{"id":458393,"name":"Engrave Chest - Cobra Slayer","icon":"spell_nature_guardianward","type":5,"classAllowlist":[2]},
{"id":458479,"name":"Engrave Boots - Wyvern Strike","icon":"inv_spear_02","type":10,"requiresLevel":1,"classAllowlist":[2]},
{"id":458856,"name":"Engrave Cloak - Divine Light","icon":"spell_holy_surgeoflight","type":4,"requiresLevel":1,"classAllowlist":[4]},
{"id":459312,"name":"Engrave Ring - Defense Specialization","icon":"inv_shield_06","type":11,"requiresLevel":1,"classAllowlist":[0,9,4,6,7,8,1]},
Expand Down
3 changes: 3 additions & 0 deletions tools/database/rune_overrides.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ var RuneOverrides = []*proto.UIRune{
// Ring - Sword Specialization
{Id: 442813, ClassAllowlist: []proto.Class{proto.Class_ClassWarrior, proto.Class_ClassPaladin, proto.Class_ClassHunter, proto.Class_ClassRogue, proto.Class_ClassMage, proto.Class_ClassWarlock}},

// Hunter
// As of 2024-06-13 Cobra Slayer is being missed by the scraper because the rune engraving ability is missing "Engrave Rune" in the name
{Id: 458393, Name: "Engrave Chest - Cobra Slayer", Icon: "spell_nature_guardianward", Type: proto.ItemType_ItemTypeChest, ClassAllowlist: []proto.Class{proto.Class_ClassHunter}},
// Warlock
// TODO: These runes haven't been updated by wowhead yet but were updated on 2024-07-03
// Cloak - Soul Siphon
Expand Down

0 comments on commit 1b13a4d

Please sign in to comment.