Skip to content

Commit

Permalink
Merge pull request #424 from wowsims/hunter-fixes
Browse files Browse the repository at this point in the history
add spell damage to hunter display stats
  • Loading branch information
rosenrusinov authored Mar 19, 2024
2 parents 6121e5c + 74d5c73 commit 53d20c2
Showing 1 changed file with 12 additions and 10 deletions.
22 changes: 12 additions & 10 deletions ui/hunter/sim.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ const SPEC_CONFIG = registerSpecConfig(Spec.SpecHunter, {
Stat.StatArmorPenetration,
Stat.StatMP5,
Stat.StatSpellPower,
Stat.StatSpellDamage,
Stat.StatNaturePower,
Stat.StatArcanePower,
],
Expand All @@ -54,22 +55,23 @@ const SPEC_CONFIG = registerSpecConfig(Spec.SpecHunter, {
Stat.StatArmorPenetration,
Stat.StatMP5,
Stat.StatSpellPower,
Stat.StatSpellDamage,
Stat.StatNaturePower,
],
modifyDisplayStats: (player: Player<Spec.SpecHunter>) => {
let stats = new Stats();
stats = stats.addStat(Stat.StatMeleeCrit, player.getTalents().lethalShots * 1 * Mechanics.MELEE_CRIT_RATING_PER_CRIT_CHANCE);

const rangedWeapon = player.getEquippedItem(ItemSlot.ItemSlotRanged);
if (rangedWeapon?.enchant?.effectId == 3608) {
stats = stats.addStat(Stat.StatMeleeCrit, 40);
}
if (player.getRace() == Race.RaceDwarf && rangedWeapon?.item.rangedWeaponType == RangedWeaponType.RangedWeaponTypeGun) {
stats = stats.addStat(Stat.StatMeleeCrit, 1 * Mechanics.MELEE_CRIT_RATING_PER_CRIT_CHANCE);
}
if (player.getRace() == Race.RaceTroll && rangedWeapon?.item.rangedWeaponType == RangedWeaponType.RangedWeaponTypeBow) {
stats = stats.addStat(Stat.StatMeleeCrit, 1 * Mechanics.MELEE_CRIT_RATING_PER_CRIT_CHANCE);
}
// const rangedWeapon = player.getEquippedItem(ItemSlot.ItemSlotRanged);
// if (rangedWeapon?.enchant?.effectId == 3608) {
// stats = stats.addStat(Stat.StatMeleeCrit, 40);
// }
// if (player.getRace() == Race.RaceDwarf && rangedWeapon?.item.rangedWeaponType == RangedWeaponType.RangedWeaponTypeGun) {
// stats = stats.addStat(Stat.StatMeleeCrit, 1 * Mechanics.MELEE_CRIT_RATING_PER_CRIT_CHANCE);
// }
// if (player.getRace() == Race.RaceTroll && rangedWeapon?.item.rangedWeaponType == RangedWeaponType.RangedWeaponTypeBow) {
// stats = stats.addStat(Stat.StatMeleeCrit, 1 * Mechanics.MELEE_CRIT_RATING_PER_CRIT_CHANCE);
// }

return {
talents: stats,
Expand Down

0 comments on commit 53d20c2

Please sign in to comment.