Skip to content

Commit

Permalink
Merge pull request #969 from wowsims/combat-potency-fok
Browse files Browse the repository at this point in the history
Prevent Combat Potency from triggering on Fan of Knives OH hits
  • Loading branch information
catszeid authored Aug 10, 2024
2 parents 561d6fc + 92eb985 commit 729dc1c
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion sim/rogue/runes.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,13 @@ func (rogue *Rogue) applyCombatPotency() {
aura.Activate(sim)
},
OnSpellHitDealt: func(aura *core.Aura, sim *core.Simulation, spell *core.Spell, result *core.SpellResult) {
if !result.Landed() || !spell.ProcMask.Matches(core.ProcMaskMeleeOH) {
isFoKOH := false

if spell.ActionID.SpellID == 409240 && spell.ActionID.Tag == 2 {
isFoKOH = true
}

if !result.Landed() || !spell.ProcMask.Matches(core.ProcMaskMeleeOH) || isFoKOH {
return
}

Expand Down

0 comments on commit 729dc1c

Please sign in to comment.