starting work on phase 7 shoulder pseudo-runes

wowsims · Dec 20, 2024 · bf21c24 · bf21c24
1 parent 57938e2
commit bf21c24
Show file tree

Hide file tree

Showing 9 changed files with 782 additions and 783 deletions.
diff --git a/assets/database/db.bin b/assets/database/db.bin
diff --git a/assets/database/db.json b/assets/database/db.json
diff --git a/assets/database/leftover_db.bin b/assets/database/leftover_db.bin
diff --git a/assets/database/leftover_db.json b/assets/database/leftover_db.json
diff --git a/assets/db_inputs/wowhead_rune_tooltips.csv b/assets/db_inputs/wowhead_rune_tooltips.csv
diff --git a/proto/ui.proto b/proto/ui.proto
@@ -182,14 +182,13 @@ message UIEnchant {
 }
 
 message UIRune {
-	reserved 4;
-	reserved "class";
+	reserved 4, 6;
+	reserved "class", "requires_level";
 
 	int32 id = 1; 
 	string name = 2;    
 	string icon = 3;
 	ItemType type = 5;
-	int32 requires_level = 6;
 	repeated Class class_allowlist = 7;
 }
 

diff --git a/tools/database/database.go b/tools/database/database.go
@@ -193,7 +193,6 @@ func (db *WowDatabase) AddRune(id int32, tooltip WowheadItemResponse) {
 		Icon:           tooltip.GetIcon(),
 		ClassAllowlist: []proto.Class{tooltip.GetRequiredClass()},
 		Type:           tooltip.GetRequiredItemSlot(),
-		RequiresLevel:  int32(tooltip.GetRequiresLevel()),
 	}
 }
 

diff --git a/tools/database/gen_db/main.go b/tools/database/gen_db/main.go
@@ -161,9 +161,7 @@ func main() {
 	}
 
 	for id, rune := range runeTooltips {
-		if !slices.Contains(database.UnimplementedRuneOverrides, id) {
-			db.AddRune(id, rune)
-		}
+		db.AddRune(id, rune)
 	}
 
 	db.MergeItems(database.ItemOverrides)

diff --git a/tools/database/rune_overrides.go b/tools/database/rune_overrides.go
@@ -46,26 +46,30 @@ var RuneOverrides = []*proto.UIRune{
 	// As of 2024-06-13 Cobra Slayer is being missed by the scraper because the rune engraving ability is missing "Engrave Rune" in the name
 	{Id: 458393, Name: "Engrave Gloves - Cobra Slayer", Icon: "spell_nature_guardianward", Type: proto.ItemType_ItemTypeHands, ClassAllowlist: []proto.Class{proto.Class_ClassHunter}},
 
-	// Warlock
-	// As of 2024-09-13 Wowhead hasn't picked up the Decimation <=> Mark of Chaos rune swap
-	{Id: 440870, Name: "Engrave Boots - Decimation", Type: proto.ItemType_ItemTypeFeet},
-	{Id: 440892, Name: "Engrave Cloak - Mark of Chaos", Type: proto.ItemType_ItemTypeBack},
-}
+	// Special should pseudo-runes
 
-// Remove runes as you implement them.
-var UnimplementedRuneOverrides = []int32{
 	// Druid
 
 	// Hunter
 
 	// Mage
+	// {Id: 1220158, Name: "Soul of Winter's Grasp", Icon: "spell_holy_divinespirit", Type: proto.ItemType_ItemTypeShoulder, ClassAllowlist: []proto.Class{proto.Class_ClassMage}},
 
 	// Paladin
-	440666, // Cloak - Vindicator
 
 	// Priest
+	// {Id: 1220134, Name: "Soul of the Zealot", Icon: "spell_holy_divinespirit", Type: proto.ItemType_ItemTypeShoulder, ClassAllowlist: []proto.Class{proto.Class_ClassPriest}},
+
+	// Rogue
 
 	// Shaman
+	// {Id: 1220232, Name: "Soul of the Windwalker", Icon: "spell_holy_divinespirit", Type: proto.ItemType_ItemTypeShoulder, ClassAllowlist: []proto.Class{proto.Class_ClassShaman}},
+	// {Id: 1220234, Name: "Soul of the Shield Master", Icon: "spell_holy_divinespirit", Type: proto.ItemType_ItemTypeShoulder, ClassAllowlist: []proto.Class{proto.Class_ClassShaman}},
+	// {Id: 1220236, Name: "Soul of the Totemic Protector", Icon: "spell_holy_divinespirit", Type: proto.ItemType_ItemTypeShoulder, ClassAllowlist: []proto.Class{proto.Class_ClassShaman}},
+	// {Id: 1220238, Name: "Soul of the Shock-Absorber", Icon: "spell_holy_divinespirit", Type: proto.ItemType_ItemTypeShoulder, ClassAllowlist: []proto.Class{proto.Class_ClassShaman}},
+	// {Id: 1220240, Name: "Soul of the Spiritual Bulwark", Icon: "spell_holy_divinespirit", Type: proto.ItemType_ItemTypeShoulder, ClassAllowlist: []proto.Class{proto.Class_ClassShaman}},
+	// {Id: 1220242, Name: "Soul of the Maelstrombringer", Icon: "spell_holy_divinespirit", Type: proto.ItemType_ItemTypeShoulder, ClassAllowlist: []proto.Class{proto.Class_ClassShaman}},
+	// {Id: 1220244, Name: "Soul of the Lavawalker", Icon: "spell_holy_divinespirit", Type: proto.ItemType_ItemTypeShoulder, ClassAllowlist: []proto.Class{proto.Class_ClassShaman}},
 
 	// Warlock