-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add +Weapon Skill tooltip parsing #127
Comments
@kayla-glick We dont do Weapon Skill with Reg-ex because its much more involved. We do it with NewItemEffects in the common/sod code. You can find examples in there I think in the melee_items.go |
Aah ok so it's done on an item-by-item basis then? |
Started to implement this for Bonk-Maestro's Handguards and Power-Assisted Lifting Belt but realized the current
|
I'm working on fixing weapon skills. It'll be overhauled completely. |
Right now our tooltip parser is missing regexes to capture +Weapon Skill effects.
https://github.com/wowsims/sod/blob/master/tools/database/wowhead_tooltips.go
The text was updated successfully, but these errors were encountered: