Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weapon Skill Refactor #214

Merged
merged 11 commits into from
Feb 17, 2024
Merged

Weapon Skill Refactor #214

merged 11 commits into from
Feb 17, 2024

Conversation

TheGroxEmpire
Copy link
Contributor

@TheGroxEmpire TheGroxEmpire commented Feb 16, 2024

  • Weapon Skills are now correctly implemented for each weapon slot
  • Attack Tables now are 2 dimensional (AttackTables[UnitIndex][CastType]). First dimension is UnitIndex, second dimension is the CastType.
  • CastType is the slot in which spell is cast from. There are three types of CastType: CastTypeMainHand, CastTypeOffHand, CastTypeRanged
  • Spells are in default cast from CastTypeMainHand
  • Spells CastType can be adjusted with SpellConfig
  • Added Wowhead tooltip parsing for weapon skills

Note to other Class Developers:

  • Please make sure to change your spell CastType if needed. Most Classes shouldn't be affected as most spells are from MainHand (this is the default Attack Table as before). However, class that has spells that are being cast from ranged or offhand such as Hunter should update those spells CastType accordingly.

@TheGroxEmpire TheGroxEmpire linked an issue Feb 17, 2024 that may be closed by this pull request
@TheGroxEmpire TheGroxEmpire marked this pull request as ready for review February 17, 2024 01:07
Copy link
Collaborator

@kayla-glick kayla-glick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative approval because attack tables still go above my head 😅

@TheGroxEmpire TheGroxEmpire merged commit c437f2e into master Feb 17, 2024
1 check passed
@TheGroxEmpire TheGroxEmpire deleted the weapon-skill-refactor branch February 17, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add +Weapon Skill tooltip parsing
2 participants