Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wing clip no longer consumes Clever Strikes #1052

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

ncberman
Copy link
Contributor

image
Most of this stuff has already been implemented or are bug fixes. Everything in the sim already works the way these patch notes are written except for the wing clip change (in this PR) and the fire frost specialization runes which I will update the hunter trap PR with

@ncberman ncberman marked this pull request as ready for review September 11, 2024 21:55
@kayla-glick kayla-glick self-requested a review September 12, 2024 18:48
Copy link
Collaborator

@kayla-glick kayla-glick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wing clip will still consume the aura because of the OnCastComplete. I mentioned on Discord, but consider setting an affectedSpells array up in an OnInit and use that in the callbacks

@ncberman
Copy link
Contributor Author

I'm going to double check functionality really quick, not sure there are any tests that use this set bonus

@kayla-glick kayla-glick merged commit 9d4be2f into wowsims:master Sep 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants