Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paladin spell flag/outcome fixes #1061

Merged
merged 14 commits into from
Sep 14, 2024
Merged

Conversation

wsphillips
Copy link
Contributor

@wsphillips wsphillips commented Sep 14, 2024

Corrected the spell flags/outcome appliers on a few abilities to be consistent with what we see in logs.

Includes:

  • Crusader Strike Spell flag to ignore resists.
  • Exorcism removed stale Exorcist rune checks (it is a book/baseline for all paladins now); the missing binary spell flag was fixed in Shockadin PTR updates #1053
  • Hammer of the Righteous always hits, can crit, can be blocked (but not dodged/parried) and deals Holy damage that doesn't get resisted. The ranged outcome applier OutcomeRangedCritOnly is the only outcome applier I could find that checks all the boxes.
  • Holy Shield does not miss.
  • Judgement of Righteousness Ignores partial resists, but otherwise has normal spell hit. Since JoR has 2 effects on wowhead db entry, assigning this as binary.

@wsphillips wsphillips marked this pull request as draft September 14, 2024 01:14
@wsphillips wsphillips marked this pull request as ready for review September 14, 2024 04:04
@kayla-glick kayla-glick merged commit cb15ae7 into wowsims:master Sep 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants