Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Add Blocked Crits metrics #1065

Merged
merged 7 commits into from
Sep 16, 2024
Merged

[UI] Add Blocked Crits metrics #1065

merged 7 commits into from
Sep 16, 2024

Conversation

1337LutZ
Copy link
Contributor

@1337LutZ 1337LutZ commented Sep 15, 2024 •
edited
Loading

  • Added Blocked Crits metric
  • Fixed desync in Metrics due to Blocked Crit counting both Blocks and Crits which would offset the Crits count when summing up values to match the Casts counter

Fixes #1056

@1337LutZ
Copy link
Contributor Author

@Adamrch Please take a look 👍

@1337LutZ 1337LutZ changed the title Attempt to fix blocks also rolling as crits [UI] Add Blocked Crits metrics Sep 16, 2024
@1337LutZ 1337LutZ merged commit e486d0e into master Sep 16, 2024
1 check passed
@1337LutZ 1337LutZ deleted the fix/block-and-crit-roll branch September 16, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SoD Rogue) Crit chance of Mutilate and Envenom is incorrect
1 participant
@1337LutZ