Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rogue Level 60 Poison Implementation #1096

Merged
merged 20 commits into from
Nov 23, 2024

Conversation

sanguinerarogue
Copy link
Contributor

Needs review, I believe the tags on the occult poison for Deadly Brew/Normal/Shiv are causing it to interfere and have different versions in sim if I use a manual imbue + deadly poison imbue. I think this also is causing it to stack with the regular Occult Debuff from the settings picker.

image
image

@sanguinerarogue sanguinerarogue marked this pull request as ready for review November 18, 2024 17:53
@sanguinerarogue sanguinerarogue changed the title Rogue Occult Poison Implementation Rogue Occult and Sebacious Poison Implementation Nov 18, 2024
@sanguinerarogue sanguinerarogue changed the title Rogue Occult and Sebacious Poison Implementation Rogue Level 60 Poison Implementation Nov 20, 2024
sim/rogue/envenom.go Outdated Show resolved Hide resolved
@sanguinerarogue sanguinerarogue merged commit ab2047a into wowsims:master Nov 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants