-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rogue Level 60 Poison Implementation #1096
Merged
sanguinerarogue
merged 20 commits into
wowsims:master
from
sanguinerarogue:RoguePoisons
Nov 23, 2024
Merged
Rogue Level 60 Poison Implementation #1096
sanguinerarogue
merged 20 commits into
wowsims:master
from
sanguinerarogue:RoguePoisons
Nov 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into RoguePoisons
…into RoguePoisons
sanguinerarogue
changed the title
Rogue Occult Poison Implementation
Rogue Occult and Sebacious Poison Implementation
Nov 18, 2024
sanguinerarogue
changed the title
Rogue Occult and Sebacious Poison Implementation
Rogue Level 60 Poison Implementation
Nov 20, 2024
kayla-glick
reviewed
Nov 23, 2024
kayla-glick
reviewed
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs review, I believe the tags on the occult poison for Deadly Brew/Normal/Shiv are causing it to interfere and have different versions in sim if I use a manual imbue + deadly poison imbue. I think this also is causing it to stack with the regular Occult Debuff from the settings picker.