Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paladin: Refactor stopattack UI options + add manually triggered attacks as an experimental feature for prot #1110

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

wsphillips
Copy link
Contributor

Protection paladins can force extra attacks gained via Reckoning to be stored until the next melee swing by manually triggering each melee swing when the swing timer is ready. By using a stopattack/@target macro on rotational abilities, we can also store WS/HoJ/etc procs gained between melee swings.

This PR adds an experimental option to simulate doing the above with perfect accuracy/timing. While possible in game (confirmed on PTR), this is difficult to do in practice and DPS gains in simulations with this feature enabled are informative but potentially misleading. Simply put: it's unlikely that even the sweatiest of prot paladins will be able to do it perfectly throughout an entire encounter, and missing the timings can have detrimental effects on DPS. As such, I have put it behind the Show Experimental option and added a simulator warning that turns on when the feature is enabled.

Nonetheless, simulating manually triggered autoattacks with slow 1H weapons yields a ~10-20% DPS increase, so I think it's worth having the option for advanced users to see the potential gains in an idealized setting.

This PR also includes some refactoring of how stopattack macros get saved and processed in the paladin spec options. It uses a bit mask + bit-shifted spell codes to make the code simpler for both protection and retribution paladins.

Comment on lines -34 to -38
righteousFury: protOptions.RighteousFury,
IsUsingDivineStormStopAttack: protOptions.IsUsingDivineStormStopAttack,
IsUsingJudgementStopAttack: protOptions.IsUsingJudgementStopAttack,
IsUsingCrusaderStrikeStopAttack: protOptions.IsUsingCrusaderStrikeStopAttack,
personalBlessing: protOptions.PersonalBlessing,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to duplicate these spec options into the Protection/Retribution structs. They're all already in the regular Options field of the paladin struct. I left primarySeal just in case, but removed the affected fields here and in the RetributionPaladin struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant