-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement off GCD apl actions #1118
base: master
Are you sure you want to change the base?
Conversation
Adamrch
commented
Oct 8, 2024
At a high level, the way the Cata sim approaches this issue in a more general way is by attaching a separate Timer pointer to the Unit in addition to the existing GCD timer. The GCD timer is only used for Unfortunately the current Cata rotation timing / spell queueing functionality was implemented piecemeal, so it's not neatly packaged into a single PR. I've gone through my commit history and put together a dump of all the relevant commits in order: wowsims/cata@eb38dcd |
I'm not trying to model spell queueing, just model in the APL doing something after a delay. It shouldn't be a single static value. It should be something exposed to the API. It seems to be working just fine without modeling spellqueueing. |
I'm not interested in porting spellqueueing over from cata at the moment because it is something completely different than what I am trying to accomplish, and would not serve the purpose I need for the ret rotation. |
I believe if we are so focused on keeping the APL the same across more versions of the game maybe we should have a git submodule for APL (that's shared across SoD and Cata) |
"Dynamic events that can trigger rotational decisions, such as auto-attacks, must simply call a ReactToEvent()" does this let you set the reaction time when you create the APL action? If I had two such actions could I set a different time for each? |