Added null check to killshot aq2.5 set #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayla-glick
reviewed
Nov 15, 2024
sim/hunter/item_sets_pve.go
Outdated
Comment on lines
465
to
467
| if hunter.KillShot != nil { | ||
| hunter.KillShot.DamageMultiplier *= 1.50 | ||
| } |
There was a problem hiding this comment.
We could probably just do this after assigning hunter to never even register the aura since this set only affects kill shot
There was a problem hiding this comment.
Actually we should do it on the 2p too now that I think about it
There was a problem hiding this comment.
Yeah good point, I added it to all the new set bonuses that are entirely focused on a rune spell
…ed on rune spells - hunter aq
kayla-glick
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to add null check for a rune spell tier set bonus