Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feral Tank set bonus #1180

Closed
wants to merge 7 commits into from
Closed

Feral Tank set bonus #1180

wants to merge 7 commits into from

Conversation

emsimpson92
Copy link
Contributor

No description provided.

kayla-glick
kayla-glick reviewed Nov 26, 2024
View reviewed changes
sim/druid/item_sets_pve.go
}
},
OnSpellHitDealt: func(aura *core.Aura, sim *core.Simulation, spell *core.Spell, result *core.SpellResult) {
if spell.SpellID == druid.MangleBear.SpellID || spell.SpellID == druid.SwipeBear.SpellID {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another knit here, but can you add SpellCodes on both spells and use that instead of the SpellID here? That's our general practice since Spell IDs don't work for anything that has multiple spell ranks available at any given time

@emsimpson92
Copy link
Contributor Author

Feedback addressed. Moving this to a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayla-glick kayla-glick kayla-glick left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emsimpson92 @kayla-glick