Hunter - T3 Melee strike reset updates #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncberman
changed the title
kayla-glick
reviewed
Jan 12, 2025
sim/hunter/item_sets_pve_phase_7.go
Outdated
Comment on lines
66
to
71
| if (spell.Flags.Matches(SpellFlagStrike) || spell.SpellCode == SpellCode_HunterMongooseBite || spell.SpellCode == SpellCode_HunterRaptorStrikeHit) && result.DidCrit() { | ||
| if spell.SpellCode == SpellCode_HunterRaptorStrikeHit { | ||
| hunter.RaptorStrike.CD.QueueReset(sim.CurrentTime) | ||
| } else { | ||
| spell.CD.Reset() | ||
| } |
There was a problem hiding this comment.
This might be slightly cleaner:
Suggested change
| if (spell.Flags.Matches(SpellFlagStrike) || spell.SpellCode == SpellCode_HunterMongooseBite || spell.SpellCode == SpellCode_HunterRaptorStrikeHit) && result.DidCrit() { | |
| if spell.SpellCode == SpellCode_HunterRaptorStrikeHit { | |
| hunter.RaptorStrike.CD.QueueReset(sim.CurrentTime) | |
| } else { | |
| spell.CD.Reset() | |
| } | |
| if (spell.Flags.Matches(SpellFlagStrike) || spell.SpellCode == SpellCode_HunterMongooseBite) && result.DidCrit() { | |
| spell.CD.Reset() | |
| } else if spell.SpellCode == SpellCode_HunterRaptorStrikeHit && result.DidCrit() { | |
| hunter.RaptorStrike.CD.QueueReset(sim.CurrentTime) | |
| } |
kayla-glick
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hunter T3 set strikes only reset themselves
Raptor Strike resets the parent spell and not the hit spell
Added a Queued Spell Reset function for spells to match real-world performance where a 2nd spell can't be queued up during a wild-strikes or HoJ extra-attack window