Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lower pet multipliers a bit more #13

Merged
merged 1 commit into from
Feb 2, 2024
Merged

lower pet multipliers a bit more #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sim/hunter/flanking_strike.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ func (hunter *Hunter) registerFlankingStrikeSpell() {
Flags: core.SpellFlagMeleeMetrics | core.SpellFlagIncludeTargetBonusDamage,

BonusCritRating: 0,
DamageMultiplier: 0.5,
DamageMultiplier: 0.45,
CritMultiplier: hunter.pet.MeleeCritMultiplier(1, 0),

ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) {
Expand Down
2 changes: 1 addition & 1 deletion sim/hunter/pet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func (hunter *Hunter) NewHunterPet() *HunterPet {

// After checking numerous logs it seems pet auto attacks are hitting for less then what they should if following standard attack formulas
// TODO: Figure out from where this difference comes
hp.AutoAttacks.MHConfig().DamageMultiplier *= 0.6
hp.AutoAttacks.MHConfig().DamageMultiplier *= 0.45

// Happiness
hp.PseudoStats.DamageDealtMultiplier *= 1.25
Expand Down
2 changes: 1 addition & 1 deletion sim/hunter/pet_abilities.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ func (hp *HunterPet) newLightningBreath() *core.Spell {
ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) {
// TODO: Figure out how LB scales as it doesnt seem to be from SP even tho the spell is listed
// with a sp mod
baseDamage := sim.Roll(baseDamageMin, baseDamageMax) + spell.MeleeAttackPower()*0.3
baseDamage := sim.Roll(baseDamageMin, baseDamageMax) + spell.MeleeAttackPower()*0.2

spell.CalcAndDealDamage(sim, target, baseDamage, spell.OutcomeMagicHitAndCrit)
},
Expand Down
Loading