Multischool fix/refactor #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayla-glick
approved these changes
Mar 25, 2024
| SpellSchool SpellSchool // Schoolmask of all schools this spell uses. Use Spell.SetSchool() to change this! | ||
| SpellSchool SpellSchool // Schoolmask of all schools this spell uses. Do not change this! Whatever you try to do is a hack and probably wrong. | ||
| SchoolIndex stats.SchoolIndex // Do not change this! Whatever you try to do is a hack and probably wrong. | ||
| SchoolBaseIndices []stats.SchoolIndex // Base school indices for multi schools. Do not change this! Whatever you try to do is a hack and probably wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the mentioned PR this only does away with the pseudo school indices and special resistance handling. There's only one index for multi schools now, because that and generated base indices are enough to handle multi schools wherever needed.
The helper for setting a spell's school is removed, because every instance of changing the school during the sim is a (lazy) hack. Changed comments to make that clear. Also made the comment on MultiSchoolShouldUseArmor more specific to clarify why it's there and what exactly the known limitations are.