Prepull Combo Point APL Addition #649
Conversation
sim/core/apl_actions_misc.go
Outdated
| if sim.Log != nil { | ||
| action.character.Log(sim, "Adding combo points (%s points)", numPoints) | ||
| } | ||
| metrics := action.character.NewComboPointMetrics(ActionID{SpellID: 432264}) |
There was a problem hiding this comment.
@sanguinerarogue and I talked about this before but this spell ID doesn't really make sense here both for Rogue (who may not even have the Rune equipped) and also since this will be useful for Feral. The problem is that you have to provide an ActionID, but you can't use a blank ID or SpellID: 0 without breaking things apparently. We could potentially use a dummy spell like Attack?
There was a problem hiding this comment.
@sanguinerarogue What you should do is create a new dummy id like we do for Attack/Move/Wait/Etc. It is added in common.proto in enum OtherAction and then add it to the switch case in action_id.ts
|
@rosenrusinov thank you for that lead. I've gone ahead and done so to create the add combo points ID.
However, now the resources tab is generating a line for each simulation for this addition (seen below). Let me know if you have seen this before or can point me in the right direction.
|
That is because you are creating a new metric on every Execute. The metric should be created once (in the apl action creation or even in the energy bar whatever feels better) and stored in the action struct and used in the execute |
|
@rosenrusinov Thank you for the help! It looks resolved now if you don't mind taking another look. |
Creating ability to add combo points to the APL via Honor Among Thieves. I had some issues with the log bugging out if sent a nil value for the SpellID so right now it is assigned to HaT. Haven't touched the APL at all so would appreciate a review.