Implement Idol of the Dream #679
Conversation
| @@ -7,19 +7,29 @@ import ( | |||
| "github.com/wowsims/sod/sim/core/proto" | |||
| ) | |||
|
|
|||
| var sodShredEffect1Mult = 0.75 // Multiply flat dmg by this | |||
There was a problem hiding this comment.
nit: for documentation, this should probably be expressed as 2.25 / (2.25 + 0.75). or use "baseMultiplier" (2.25) and "sodBonusMultiplier" (0.75) as constants, and use only them, preferably within the function, as to not leak 'em into the package namespace (and allow shorter names).
There was a problem hiding this comment.
Looks like https://www.wowhead.com/classic/spell=436895/s03-tuning-and-overrides-passive-druid explicitly lowers the base damage (-25%) via "Apply Aura: Modifies Effect #1's Value", and this applies after the "regular" changes.
There was a problem hiding this comment.
Yeah, I wanted to recreate what the game does, hence the explicit 0.75 multiplier for effect1. But yes, naming and placement of the vars isn't optimal, made that in a hurry :D
Order for percentage "all effects" and "effect #" mods on the server side is unknown, but because it's both multiplicative it doesn't matter, unlike for the flat additive one for effect 2.
From testing it at the shimmering flats dummy the 2% seem to increase the flat added damage, and the multiplier before the extra 75% from SoD are added.