Implement programmatic ActionID level filtering for pickers #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayla-glick
commented
Feb 1, 2024
ui/core/player.ts
Outdated
Comment on lines
1304
to
1327
| getMatchingSpellActionId(src: number[][]): ActionId | null { | ||
| const match = src.find(([_, minLevel, maxLevel]) => | ||
| (!minLevel || minLevel <= this.getLevel()) && | ||
| (!maxLevel || maxLevel >= this.getLevel()) | ||
| ) | ||
|
|
||
| console.log(this.getLevel(), match) | ||
|
|
||
| if (match) return ActionId.fromSpellId(match[0]) | ||
| return null | ||
| } | ||
|
|
||
| // Filter a matrix of item IDs, min and max levels for a matching item ID | ||
| getMatchingItemActionId(src: number[][]): ActionId | null { | ||
| const match = src.find(([_, minLevel, maxLevel]) => | ||
| (!minLevel || minLevel <= this.getLevel()) && | ||
| (!maxLevel || maxLevel >= this.getLevel()) | ||
| ) | ||
|
|
||
| console.log(this.getLevel(), match) | ||
|
|
||
| if (match) return ActionId.fromItemId(match[0]) | ||
| return null | ||
| } |
There was a problem hiding this comment.
These functions take in a matrix of up to 3-length arrays representing the item ID, a minimum level to display the buff, and a maximum level to display the buff (if applicable) and finds the correct entry corresponding to the player's current level and returns the ActionID from that entry.
kayla-glick
commented
Feb 1, 2024
Comment on lines
31
to
39
| actionId: (player) => player.getMatchingSpellActionId([ | ||
| [1126, 1, 9], | ||
| [5232, 10, 19], | ||
| [6756, 20, 29], | ||
| [5234, 30, 39], | ||
| [8907, 40, 49], | ||
| [9884, 50, 59], | ||
| [9885, 60] | ||
| ]), impId: ActionId.fromSpellId(17055), fieldName: 'giftOfTheWild'}), |
There was a problem hiding this comment.
Here are some examples of how this is used to conditionally display the correct buff ranks
kayla-glick
commented
Feb 1, 2024
ui/core/components/icon_picker.tsx
Outdated
Comment on lines
84
to
89
| const fillActionid = () => this.config.actionId(this.modObject)?.fillAndSet(this.rootAnchor, true, true); | ||
| this.config.changedEvent(this.modObject).on(() => { | ||
| console.log('good') | ||
| fillActionid() | ||
| }) | ||
| fillActionid() |
There was a problem hiding this comment.
We change this to a function so that we can key off of the changedEvent to update Action IDs each time
kayla-glick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.