Updated Base ranged range and MS #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adocoD
changed the title
kayla-glick
reviewed
Jul 8, 2024
kayla-glick
reviewed
Jul 8, 2024
sim/hunter/aimed_shot.go
Outdated
| @@ -56,7 +56,7 @@ func (hunter *Hunter) getAimedShotConfig(rank int, timer *core.Timer) core.Spell | |||
| }, | |||
| }, | |||
| ExtraCastCondition: func(sim *core.Simulation, target *core.Unit) bool { | |||
| return hunter.DistanceFromTarget >= 8 | |||
| return hunter.DistanceFromTarget >= 12 | |||
There was a problem hiding this comment.
Maybe we could pull this out into a constant value in sim/core/constants? core.MinRangedAttackDistance
There was a problem hiding this comment.
Added constant for both MaxMeleeAttackDistance and MinRangedAttackDistance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hunter melee and ranged only had a difference of 3 yds. It should actually be 7.
Hunter range to boss gets calculated from edge of hitbox. Since melee range in the sim is 5 (4+1), ranged would be 12 (4+8).
Movement speed was also incorrect , so changed it to 7yd per second.