Merge pull request #265 from wowsims/enhance

Fix a few bugs
wowsims · Jan 26, 2022 · dd67aff · dd67aff
2 parents 516f978 + ad53ca9
commit dd67aff
Show file tree

Hide file tree

Showing 7 changed files with 276 additions and 277 deletions.
diff --git a/sim/core/items/all_enchants.go b/sim/core/items/all_enchants.go
@@ -66,7 +66,7 @@ var Enchants = []Enchant{
 	{ID: 22560, EffectID: 2671, Name: "Sunfire", Quality: proto.ItemQuality_ItemQualityRare, Bonus: stats.Stats{stats.ArcaneSpellPower: 50, stats.FireSpellPower: 50}, ItemType: proto.ItemType_ItemTypeWeapon},
 	{ID: 22561, EffectID: 2672, Name: "Soulfrost", Quality: proto.ItemQuality_ItemQualityRare, Bonus: stats.Stats{stats.FrostSpellPower: 50, stats.ShadowSpellPower: 50}, ItemType: proto.ItemType_ItemTypeWeapon},
 	{ID: 22559, EffectID: 2673, Name: "Weapon - Mongoose", Quality: proto.ItemQuality_ItemQualityRare, Bonus: stats.Stats{}, ItemType: proto.ItemType_ItemTypeWeapon},
-	{ID: 42620, EffectID: 3222, Name: "Weapon - Greater Agility", Quality: proto.ItemQuality_ItemQualityCommon, Bonus: stats.Stats{stats.Agility: 20}, ItemType: proto.ItemType_ItemTypeWeapon},
+	{ID: 33165, EffectID: 3222, Name: "Weapon - Greater Agility", Quality: proto.ItemQuality_ItemQualityCommon, Bonus: stats.Stats{stats.Agility: 20}, ItemType: proto.ItemType_ItemTypeWeapon},
 	// TODO: Crusader, spellsurge, executioner
 
 	// Shield

diff --git a/sim/core/racials.go b/sim/core/racials.go
@@ -201,7 +201,6 @@ func applyRaceEffects(agent Agent) {
 					})
 					character.SpendMana(sim, manaCost, actionID)
 					character.Metrics.AddInstantCast(actionID)
-					character.AddAuraUptime(TrollBerserkingAuraID, actionID, MinDuration(dur, sim.Duration-sim.CurrentTime))
 				}
 			},
 		})

diff --git a/sim/raid_test.go b/sim/raid_test.go
@@ -112,5 +112,5 @@ func TestBasicRaid(t *testing.T) {
 		SimOptions: SimOptions,
 	}
 
-	core.RaidSimTest("P1 ST", t, rsr, 4135.06707)
+	core.RaidSimTest("P1 ST", t, rsr, 4091.0)
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -201,7 +201,6 @@ func applyRaceEffects(agent Agent) { @@
     					})
     					character.SpendMana(sim, manaCost, actionID)
     					character.Metrics.AddInstantCast(actionID)
-    					character.AddAuraUptime(TrollBerserkingAuraID, actionID, MinDuration(dur, sim.Duration-sim.CurrentTime))
     				}
     			},
     		})
@@ Expand Down @@