ui/db: 'unify' expose / sunder action id's

- expose no longer has a rank - unify sunder armor action id to always use 'highest' rank - this avoids more unneeded requests Signed-off-by: jarves <[email protected]>
wowsims · Jan 11, 2023 · 3d9114f · 3d9114f
1 parent cc90f8b
commit 3d9114f
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 5 deletions.
diff --git a/assets/database/db.bin b/assets/database/db.bin
diff --git a/assets/database/db.json b/assets/database/db.json
@@ -9378,7 +9378,6 @@
 {"id":5926,"name":"Holy Power","icon":"spell_holy_power"},
 {"id":5952,"name":"Throwing Specialization","icon":"ability_rogue_throwingspecialization"},
 {"id":6562,"name":"Heroic Presence","icon":"inv_helmet_21"},
-{"id":7386,"name":"Sunder Armor","icon":"ability_warrior_sunder"},
 {"id":8647,"name":"Expose Armor","icon":"ability_warrior_riposte"},
 {"id":9452,"name":"Vindication","icon":"spell_holy_vindication"},
 {"id":9453,"name":"Unyielding Faith","icon":"spell_holy_unyieldingfaith"},
@@ -11017,6 +11016,7 @@
 {"id":47436,"name":"Battle Shout","icon":"ability_warrior_battleshout"},
 {"id":47437,"name":"Demoralizing Shout","icon":"ability_warrior_warcry"},
 {"id":47440,"name":"Commanding Shout","icon":"ability_warrior_rallyingcry"},
+{"id":47467,"name":"Sunder Armor","icon":"ability_warrior_sunder"},
 {"id":47502,"name":"Thunder Clap","icon":"spell_nature_thunderclap"},
 {"id":47507,"name":"Aspiration","icon":"spell_holy_aspiration"},
 {"id":47508,"name":"Aspiration","icon":"spell_holy_aspiration"},

diff --git a/sim/core/debuffs.go b/sim/core/debuffs.go
@@ -609,7 +609,7 @@ func ExposeArmorAura(target *Unit, hasGlyph bool) *Aura {
 	const armorReduction = 0.2
 	aura := target.GetOrRegisterAura(Aura{
 		Label:    "ExposeArmor",
-		ActionID: ActionID{SpellID: 48669},
+		ActionID: ActionID{SpellID: 8647},
 		Duration: time.Second * TernaryDuration(hasGlyph, 42, 30),
 	})
 

diff --git a/tools/database/overrides.go b/tools/database/overrides.go
@@ -474,8 +474,8 @@ var SharedSpellsIcons = []int32{
 	54648,
 
 	// Raid Debuffs
-	7386,
 	8647,
+	47467,
 	55754,
 
 	770,

diff --git a/ui/core/components/icon_inputs.ts b/ui/core/components/icon_inputs.ts
@@ -183,7 +183,7 @@ export const RevitalizeWildGrowth = makeMultistateMultiplierIndividualBuffInput(
 // Debuffs
 
 export const MajorArmorDebuff = InputHelpers.makeMultiIconInput([
-	makeBooleanDebuffInput(ActionId.fromSpellId(7386), 'sunderArmor'),
+	makeBooleanDebuffInput(ActionId.fromSpellId(47467), 'sunderArmor'),
 	makeBooleanDebuffInput(ActionId.fromSpellId(8647), 'exposeArmor'),
 	makeBooleanDebuffInput(ActionId.fromSpellId(55754), 'acidSpit'),
 ], 'Major ArP');

diff --git a/ui/raid/raid_stats.ts b/ui/raid/raid_stats.ts
@@ -817,7 +817,7 @@ const RAID_STATS_OPTIONS: RaidStatsOptions = {sections: [
 				effects: [
 					{
 						label: 'Sunder Armor',
-						actionId: ActionId.fromSpellId(7386),
+						actionId: ActionId.fromSpellId(47467),
 						playerData: playerClass(Class.ClassWarrior, player => player.isSpec(Spec.SpecProtectionWarrior) || (player as Player<Spec.SpecWarrior>).getRotation().sunderArmor == SunderArmor.SunderArmorMaintain),
 					},
 					{
-Original file line number
+Diff line change
@@ Expand Up / @@ -474,8 +474,8 @@ var SharedSpellsIcons = []int32{ @@
 ,
     	// Raid Debuffs
-,
 ,
+,
 ,
 ,
@@ Expand Down @@