Skip to content

Commit

Permalink
Merge pull request #3173 from Horatio27/enh_tier10_snapshot_fix
Browse files Browse the repository at this point in the history
Hotfix for Enh Tier 10 snapshotting
  • Loading branch information
Horatio27 authored Jun 18, 2023
2 parents 9bde2c5 + 525ac85 commit 5b19813
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion sim/shaman/fire_elemental_totem.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func (shaman *Shaman) registerFireElementalTotem() {
success := false
if enhTier10Aura != nil && shaman.Totems.EnhTierTenBonus {
if enhTier10Aura.IsActive() {
success = shaman.fireElementalSnapShot.CanSnapShot(sim, enhTier10Aura.RemainingDuration(sim))
success = shaman.fireElementalSnapShot.CanSnapShot(sim, castWindow)
}
} else if sim.CurrentTime > 1*time.Second && shaman.fireElementalSnapShot == nil {
success = true
Expand Down
3 changes: 3 additions & 0 deletions sim/shaman/shaman.go
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,9 @@ func (shaman *Shaman) setupProcTrackers() {
snapshotManager.AddProc(71561, "Deathbringer's Will H Agility Proc", false)
snapshotManager.AddProc(71492, "Deathbringer's Will AP Proc", false)
snapshotManager.AddProc(71561, "Deathbringer's Will H AP Proc", false)

// Tier Bonus
snapshotManager.AddProc(70831, "Maelstrom Power", false)
}

func (shaman *Shaman) setupFireElementalCooldowns() {
Expand Down
4 changes: 2 additions & 2 deletions ui/core/components/fire_elemental_inputs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ export function FireElementalSection(parentElem: HTMLElement, simUI: IndividualS

new NumberPicker(contentBlock.bodyElement, simUI.player, {
positive: true,
label: "Bonus Spellpower",
labelTooltip: "Bonus Spellpower to snapshot Fire Elemental with. Will prioritize dropping Fire Elemental if greater then 0",
label: "Bonus spell power",
labelTooltip: "Bonus spell power to snapshot Fire Elemental with. Will prioritize dropping Fire Elemental if greater then 0",
inline: true,
getValue: (player: Player<ShamanSpecs>) => player.getRotation().totems?.bonusSpellpower || 0,
setValue: (eventID: EventID, player: Player<ShamanSpecs>, newVal: number) => {
Expand Down

0 comments on commit 5b19813

Please sign in to comment.