Merge pull request #1535 from wowsims/add_unseen

added unseen idol and tests
wowsims · Oct 30, 2022 · 6bd7798 · 6bd7798
2 parents 4dc81bd + eb80b72
commit 6bd7798
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 1 deletion.
diff --git a/sim/core/items/all_items.go b/sim/core/items/all_items.go
@@ -3714,6 +3714,7 @@ var Items = []Item{
 	{Name: "Idol of the Raven Goddess", ID: 32387, Type: proto.ItemType_ItemTypeRanged, RangedWeaponType: proto.RangedWeaponType_RangedWeaponTypeIdol, Phase: 1, Quality: proto.ItemQuality_ItemQualityRare, Unique: true, Ilvl: 115, Stats: stats.Stats{}},
 	{Name: "Idol of the Ravenous Beast", ID: 40713, ClassAllowlist: []proto.Class{proto.Class_ClassDruid}, Type: proto.ItemType_ItemTypeRanged, RangedWeaponType: proto.RangedWeaponType_RangedWeaponTypeIdol, Phase: 1, Quality: proto.ItemQuality_ItemQualityEpic, Unique: true, Ilvl: 200, Stats: stats.Stats{}},
 	{Name: "Idol of the Shooting Star", ID: 40321, Type: proto.ItemType_ItemTypeRanged, RangedWeaponType: proto.RangedWeaponType_RangedWeaponTypeIdol, Phase: 1, Quality: proto.ItemQuality_ItemQualityEpic, Unique: true, Ilvl: 213, Stats: stats.Stats{}},
+	{Name: "Idol of the Unseen Moon", ID: 33510, Type: proto.ItemType_ItemTypeRanged, RangedWeaponType: proto.RangedWeaponType_RangedWeaponTypeIdol, Phase: 1, Quality: proto.ItemQuality_ItemQualityEpic, Unique: true, Ilvl: 128, Stats: stats.Stats{}},
 	{Name: "Idol of the White Stag", ID: 32257, Type: proto.ItemType_ItemTypeRanged, RangedWeaponType: proto.RangedWeaponType_RangedWeaponTypeIdol, Phase: 1, Quality: proto.ItemQuality_ItemQualityEpic, Unique: true, Ilvl: 141, Stats: stats.Stats{}},
 	{Name: "Igniter Rod", ID: 45314, Type: proto.ItemType_ItemTypeWeapon, WeaponType: proto.WeaponType_WeaponTypeOffHand, HandType: proto.HandType_HandTypeOffHand, Phase: 2, Quality: proto.ItemQuality_ItemQualityEpic, Ilvl: 219, Stats: stats.Stats{stats.Stamina: 44, stats.Intellect: 45, stats.Spirit: 36, stats.SpellPower: 64, stats.SpellCrit: 47, stats.MeleeCrit: 47}},
 	{Name: "Ikfirus's Sack of Wonder", ID: 50001, Type: proto.ItemType_ItemTypeChest, ArmorType: proto.ArmorType_ArmorTypeLeather, Phase: 4, Quality: proto.ItemQuality_ItemQualityEpic, Ilvl: 264, Stats: stats.Stats{stats.Agility: 146, stats.Stamina: 162, stats.SpellHit: 100, stats.AttackPower: 200, stats.MeleeHit: 100, stats.Expertise: 92, stats.Armor: 665, stats.RangedAttackPower: 200}, GemSockets: []proto.GemColor{proto.GemColor_GemColorRed, proto.GemColor_GemColorBlue, proto.GemColor_GemColorYellow}, SocketBonus: stats.Stats{stats.Agility: 8}},

diff --git a/sim/druid/balance/TestBalance.results b/sim/druid/balance/TestBalance.results
@@ -294,6 +294,13 @@ dps_results: {
   tps: 7130.53762
  }
 }
+dps_results: {
+ key: "TestBalance-AllItems-IdoloftheUnseenMoon-33510"
+ value: {
+  dps: 7238.99389
+  tps: 7084.28042
+ }
+}
 dps_results: {
  key: "TestBalance-AllItems-IdoloftheWhiteStag-32257"
  value: {

diff --git a/sim/druid/feral/TestFeral.results b/sim/druid/feral/TestFeral.results
@@ -287,6 +287,13 @@ dps_results: {
   tps: 5523.40335
  }
 }
+dps_results: {
+ key: "TestFeral-AllItems-IdoloftheUnseenMoon-33510"
+ value: {
+  dps: 7220.58251
+  tps: 5468.33614
+ }
+}
 dps_results: {
  key: "TestFeral-AllItems-IdoloftheWhiteStag-32257"
  value: {

diff --git a/sim/druid/tank/TestFeralTank.results b/sim/druid/tank/TestFeralTank.results
@@ -287,6 +287,13 @@ dps_results: {
   tps: 1441.96125
  }
 }
+dps_results: {
+ key: "TestFeralTank-AllItems-IdoloftheUnseenMoon-33510"
+ value: {
+  dps: 1066.80495
+  tps: 1441.96125
+ }
+}
 dps_results: {
  key: "TestFeralTank-AllItems-IdoloftheWhiteStag-32257"
  value: {

diff --git a/tools/generate_items/writer.go b/tools/generate_items/writer.go
@@ -316,7 +316,7 @@ var denyListNameRegexes = []*regexp.Regexp{
 
 // allowList allows overriding to allow an item
 var allowList = map[int]bool{
-	// 33510: true, // Unseen moon idol
+	33510: true, // Unseen moon idol
 	34473: true, // Commendation of Kael'thas
 	29994: true, // Thalassian Wildercloak
 	30627: true, // Tsunami Talisman