Merge pull request #4129 from wowsims/fixes

Remove legacy warrior options from tests to make sure they aren't affecting results

sim/warrior/dps/dps_warrior_test.go

@@ -111,61 +111,17 @@ var ArmsGlyphs = &proto.Glyphs{
 var PlayerOptionsArms = &proto.Player_Warrior{
 	Warrior: &proto.Warrior{
 		Options:  warriorOptions,
-		Rotation: armsRotation,
+		Rotation: &proto.Warrior_Rotation{},
 	},
 }
 
 var PlayerOptionsFury = &proto.Player_Warrior{
 	Warrior: &proto.Warrior{
 		Options:  warriorOptions,
-		Rotation: furyRotation,
+		Rotation: &proto.Warrior_Rotation{},
 	},
 }
 
-var armsRotation = &proto.Warrior_Rotation{
-	UseRend:   true,
-	UseMs:     true,
-	UseCleave: false,
-
-	HsRageThreshold:          50,
-	MsRageThreshold:          35,
-	SlamRageThreshold:        25,
-	RendCdThreshold:          0,
-	RendHealthThresholdAbove: 0,
-
-	SpamExecute: false,
-
-	UseHsDuringExecute: true,
-
-	MaintainDemoShout:   false,
-	MaintainThunderClap: false,
-
-	StanceOption: proto.Warrior_Rotation_DefaultStance,
-}
-
-var furyRotation = &proto.Warrior_Rotation{
-	UseRend:               true,
-	UseCleave:             false,
-	UseOverpower:          true,
-	ExecutePhaseOverpower: false,
-
-	HsRageThreshold:          30,
-	RendRageThresholdBelow:   100,
-	SlamRageThreshold:        25,
-	RendCdThreshold:          0,
-	RendHealthThresholdAbove: 20,
-
-	UseHsDuringExecute: true,
-	UseWwDuringExecute: true,
-	UseBtDuringExecute: true,
-	UseSlamOverExecute: true,
-
-	MaintainDemoShout:   false,
-	MaintainThunderClap: false,
-
-	StanceOption: proto.Warrior_Rotation_DefaultStance,
-}
-
 var warriorOptions = &proto.Warrior_Options{
 	StartingRage:       50,
 	UseRecklessness:    true,