[core] rename DualWielding() "back" to IsDualWielding()

wowsims · Oct 26, 2023 · a6c8c67 · a6c8c67
1 parent 3ae07b3
commit a6c8c67
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/sim/common/wotlk/capacitors.go b/sim/common/wotlk/capacitors.go
@@ -193,7 +193,7 @@ func init() {
 					},
 				})
 
-				if character.AutoAttacks.DualWielding() {
+				if character.AutoAttacks.IsDualWielding() {
 					ohSpell = character.GetOrRegisterSpell(core.SpellConfig{
 						ActionID:         core.ActionID{SpellID: 71434}, // "Manifest Anger"
 						SpellSchool:      core.SpellSchoolPhysical,

diff --git a/sim/core/attack.go b/sim/core/attack.go
@@ -165,7 +165,7 @@ func (spell *Spell) IsMelee() bool {
 	return spell.ProcMask.Matches(ProcMaskMelee)
 }
 
-func (aa *AutoAttacks) DualWielding() bool {
+func (aa *AutoAttacks) IsDualWielding() bool {
 	return aa.isDualWielding
 }
 

diff --git a/sim/core/spell_outcome.go b/sim/core/spell_outcome.go
@@ -378,7 +378,7 @@ func (spell *Spell) fixedCritCheck(sim *Simulation, critChance float64) bool {
 
 func (result *SpellResult) applyAttackTableMiss(spell *Spell, attackTable *AttackTable, roll float64, chance *float64) bool {
 	missChance := attackTable.BaseMissChance - spell.PhysicalHitChance(attackTable)
-	if spell.Unit.AutoAttacks.DualWielding() && !spell.Unit.PseudoStats.DisableDWMissPenalty {
+	if spell.Unit.AutoAttacks.IsDualWielding() && !spell.Unit.PseudoStats.DisableDWMissPenalty {
 		missChance += 0.19
 	}
 	*chance = max(0, missChance)
@@ -505,7 +505,7 @@ func (result *SpellResult) applyAttackTableHit(spell *Spell) {
 
 func (result *SpellResult) applyEnemyAttackTableMiss(spell *Spell, attackTable *AttackTable, roll float64, chance *float64) bool {
 	missChance := attackTable.BaseMissChance + spell.Unit.PseudoStats.IncreasedMissChance + result.Target.GetDiminishedMissChance() + result.Target.PseudoStats.ReducedPhysicalHitTakenChance
-	if spell.Unit.AutoAttacks.DualWielding() && !spell.Unit.PseudoStats.DisableDWMissPenalty {
+	if spell.Unit.AutoAttacks.IsDualWielding() && !spell.Unit.PseudoStats.DisableDWMissPenalty {
 		missChance += 0.19
 	}
 	*chance = max(0, missChance)

diff --git a/sim/shaman/enhancement/priority_rotation.go b/sim/shaman/enhancement/priority_rotation.go
@@ -202,7 +202,7 @@ func (rotation *PriorityRotation) buildPriorityRotation(enh *EnhancementShaman)
 	lavaLash := Spell{
 		condition: func(sim *core.Simulation, target *core.Unit) bool {
 			//Checking if we learned the spell, ie untalented
-			return enh.LavaLash != nil && enh.AutoAttacks.DualWielding()
+			return enh.LavaLash != nil && enh.AutoAttacks.IsDualWielding()
 		},
 		cast: func(sim *core.Simulation, target *core.Unit) bool {
 			//TODO add in LL delay so we don't lose flametongues, if Last attack = current time

diff --git a/sim/shaman/stormstrike.go b/sim/shaman/stormstrike.go
@@ -134,7 +134,7 @@ func (shaman *Shaman) registerStormstrikeSpell() {
 
 				mhHit(sim, target, spell)
 
-				if shaman.AutoAttacks.DualWielding() {
+				if shaman.AutoAttacks.IsDualWielding() {
 					ohHit(sim, target, spell)
 				}
 

diff --git a/sim/warrior/talents.go b/sim/warrior/talents.go
@@ -353,7 +353,7 @@ func (warrior *Warrior) applyTitansGrip() {
 	if !warrior.Talents.TitansGrip {
 		return
 	}
-	if !warrior.AutoAttacks.DualWielding() {
+	if !warrior.AutoAttacks.IsDualWielding() {
 		return
 	}
 	if warrior.MainHand().HandType != proto.HandType_HandTypeTwoHand && warrior.OffHand().HandType != proto.HandType_HandTypeTwoHand {
@@ -788,7 +788,7 @@ func (warrior *Warrior) RegisterBladestormCD() {
 	numHits := min(4, warrior.Env.GetNumTargets())
 	results := make([]*core.SpellResult, numHits)
 
-	if warrior.AutoAttacks.DualWielding() {
+	if warrior.AutoAttacks.IsDualWielding() {
 		warrior.BladestormOH = warrior.RegisterSpell(core.SpellConfig{
 			ActionID:    actionID,
 			SpellSchool: core.SpellSchoolPhysical,

diff --git a/sim/warrior/whirlwind.go b/sim/warrior/whirlwind.go
@@ -12,7 +12,7 @@ func (warrior *Warrior) registerWhirlwindSpell() {
 	numHits := min(4, warrior.Env.GetNumTargets())
 	results := make([]*core.SpellResult, numHits)
 
-	if warrior.AutoAttacks.DualWielding() && warrior.GetOHWeapon().WeaponType != proto.WeaponType_WeaponTypeStaff &&
+	if warrior.AutoAttacks.IsDualWielding() && warrior.GetOHWeapon().WeaponType != proto.WeaponType_WeaponTypeStaff &&
 		warrior.GetOHWeapon().WeaponType != proto.WeaponType_WeaponTypePolearm {
 		warrior.WhirlwindOH = warrior.RegisterSpell(core.SpellConfig{
 			ActionID:    actionID.WithTag(1),