Skip to content

Commit

Permalink
Merge from master
Browse files Browse the repository at this point in the history
jimmyt857 committed Oct 17, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
2 parents 7e5ceab + 6868808 commit ca0a513
Showing 13 changed files with 724 additions and 707 deletions.
2 changes: 1 addition & 1 deletion sim/deathknight/blood_tap.go
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@ func (dk *Deathknight) registerBloodTapSpell() {

dk.BloodTap = dk.RegisterSpell(core.SpellConfig{
ActionID: actionID,
Flags: core.SpellFlagNoOnCastComplete | core.SpellFlagAPL,
Flags: core.SpellFlagAPL,

Cast: core.CastConfig{
CD: core.Cooldown{
2 changes: 1 addition & 1 deletion sim/deathknight/dancing_rune_weapon.go
Original file line number Diff line number Diff line change
@@ -144,7 +144,7 @@ func (dk *Deathknight) NewRuneWeapon() *RuneWeaponPet {
}, func(ownerStats stats.Stats) stats.Stats {
return stats.Stats{
stats.AttackPower: ownerStats[stats.AttackPower],
stats.MeleeHaste: ownerStats[stats.MeleeHaste] * PetHasteScale,
stats.MeleeHaste: ownerStats[stats.MeleeHaste],

stats.MeleeHit: ownerStats[stats.MeleeHit],
stats.SpellHit: ownerStats[stats.MeleeHit] * PetSpellHitScale,
6 changes: 3 additions & 3 deletions sim/deathknight/deathknight.go
Original file line number Diff line number Diff line change
@@ -19,9 +19,9 @@ const (
)

const (
PetSpellHitScale = 17.0 / 8.0 * core.SpellHitRatingPerHitChance / core.MeleeHitRatingPerHitChance // 1.7
PetExpertiseScale = 3.25 * core.ExpertisePerQuarterPercentReduction / core.MeleeHitRatingPerHitChance // 0.8125
PetHasteScale = core.HasteRatingPerHastePercent / (core.HasteRatingPerHastePercent / 1.3) // 1.3
PetSpellHitScale = 17.0 / 8.0 * core.SpellHitRatingPerHitChance / core.MeleeHitRatingPerHitChance // 1.7
PetExpertiseScale = 3.25 * core.ExpertisePerQuarterPercentReduction / core.MeleeHitRatingPerHitChance // 0.8125
PetSpellHasteScale = 1.3
)

var TalentTreeSizes = [3]int{28, 29, 31}
Loading

0 comments on commit ca0a513

Please sign in to comment.