Inline new function since its only used once

wowsims · Jan 6, 2024 · cfececa · cfececa
1 parent ba69e78
commit cfececa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/sim/core/apl_helpers.go b/sim/core/apl_helpers.go
@@ -148,7 +148,12 @@ func (rot *APLRotation) GetAPLSpell(spellId *proto.ActionID) *Spell {
 			}
 		}
 	} else {
-		spell = rot.unit.GetSpellAPL(actionID)
+		for _, s := range rot.unit.Spellbook {
+			if s.ActionID.SameAction(actionID) && s.Flags.Matches(SpellFlagAPL) {
+				spell = s
+				break
+			}
+		}
 	}
 
 	if spell == nil {

diff --git a/sim/core/spell.go b/sim/core/spell.go
@@ -311,16 +311,6 @@ func (unit *Unit) GetSpell(actionID ActionID) *Spell {
 	return nil
 }
 
-// Like GetSpell, but only returns spells with the APL flag set.
-func (unit *Unit) GetSpellAPL(actionID ActionID) *Spell {
-	for _, spell := range unit.Spellbook {
-		if spell.ActionID.SameAction(actionID) && spell.Flags.Matches(SpellFlagAPL) {
-			return spell
-		}
-	}
-	return nil
-}
-
 // Retrieves an existing spell with the same ID as the config uses, or registers it if there is none.
 func (unit *Unit) GetOrRegisterSpell(config SpellConfig) *Spell {
 	registered := unit.GetSpell(config.ActionID)