Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warrior DPS crit cap will disregard dual wield miss #3882

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Warrior DPS crit cap will disregard dual wield miss #3882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui/core/player.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,8 @@ export class Player<SpecType extends Spec> {
const glancing = 24.0;

const hasOffhandWeapon = this.getGear().getEquippedItem(ItemSlot.ItemSlotOffHand)?.item.weaponSpeed !== undefined;
const meleeHitCap = hasOffhandWeapon ? 27.0 : 8.0;
// Due to warrior HS bug, hit cap for crit cap calculation should be 8% instead of 27%
const meleeHitCap = hasOffhandWeapon && this.spec != Spec.SpecWarrior ? 27.0 : 8.0;
const expertiseCap = this.getInFrontOfTarget() ? 20.5 : 6.5;

const remainingMeleeHitCap = Math.max(meleeHitCap - meleeHit, 0.0);
Expand Down