Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Bryntroll PPM from 2 to 1 according to the latest test data #3898

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Change Bryntroll PPM from 2 to 1 according to the latest test data #3898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sim/common/wotlk/other_effects.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,7 @@ func init() {
character := agent.GetCharacter()

procMask := character.GetProcMaskForItem(itemID)
ppmm := character.AutoAttacks.NewPPMManager(2.0, procMask)
ppmm := character.AutoAttacks.NewPPMManager(1.0, procMask)

procActionID := core.ActionID{ItemID: itemID}

Expand Down
8 changes: 4 additions & 4 deletions sim/deathknight/dps/TestBlood.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,15 @@ dps_results: {
dps_results: {
key: "TestBlood-AllItems-Bryntroll,theBoneArbiter-50415"
value: {
dps: 12555.20551
tps: 6415.64804
dps: 12482.10937
tps: 6377.5949
}
}
dps_results: {
key: "TestBlood-AllItems-Bryntroll,theBoneArbiter-50709"
value: {
dps: 12650.98182
tps: 6476.10052
dps: 12582.39284
tps: 6432.13894
}
}
dps_results: {
Expand Down
8 changes: 4 additions & 4 deletions sim/deathknight/tank/TestBloodTank.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,15 @@ dps_results: {
dps_results: {
key: "TestBloodTank-AllItems-Bryntroll,theBoneArbiter-50415"
value: {
dps: 2536.97604
tps: 7472.48013
dps: 2495.52846
tps: 7359.57533
}
}
dps_results: {
key: "TestBloodTank-AllItems-Bryntroll,theBoneArbiter-50709"
value: {
dps: 2596.82022
tps: 7555.12826
dps: 2550.21122
tps: 7484.77721
}
}
dps_results: {
Expand Down
8 changes: 4 additions & 4 deletions sim/warrior/dps/TestArms.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,15 @@ dps_results: {
dps_results: {
key: "TestArms-AllItems-Bryntroll,theBoneArbiter-50415"
value: {
dps: 8582.8993
tps: 7057.14544
dps: 8513.27261
tps: 7001.4441
}
}
dps_results: {
key: "TestArms-AllItems-Bryntroll,theBoneArbiter-50709"
value: {
dps: 8690.57752
tps: 7136.47654
dps: 8621.03902
tps: 7080.84574
}
}
dps_results: {
Expand Down
Loading