Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blood tap as a major defensive CD option when 4pc T10 is present #4029

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Add blood tap as a major defensive CD option when 4pc T10 is present #4029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31fbe02
Add blood tap as a major defensive CD option when 4pc T9 is present
Nov 11, 2023
189cd26
Update the newly added tooltip for blood tap prio to reference the co…
Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sim/deathknight/blood_tap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,11 @@ func (dk *Deathknight) registerBloodTapSpell() {
dk.BloodTapAura.Activate(sim)
},
})

if !dk.Inputs.IsDps && dk.HasSetBonus(ItemSetScourgelordsPlate, 4) {
dk.AddMajorCooldown(core.MajorCooldown{
Spell: dk.BloodTap,
Type: core.CooldownTypeSurvival,
})
}
}
4 changes: 2 additions & 2 deletions sim/deathknight/tank/TestBloodTank.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,8 +603,8 @@ dps_results: {
dps_results: {
key: "TestBloodTank-AllItems-Scourgelord'sPlate"
value: {
dps: 2378.234
tps: 7409.94516
dps: 2369.21163
tps: 7920.62357
}
}
dps_results: {
Expand Down
4 changes: 2 additions & 2 deletions ui/tank_deathknight/inputs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ export const TankDeathKnightRotationConfig = {
fieldName: 'bloodTapPrio',
label: 'Blood Tap',
labelTooltip: 'Chose how to use Blood Tap:<br>\
<b>Defensive</b>: Save Blood Tap for activating defensive cds.<br>\
<b>Use as Defensive Cooldown</b>: Use as defined in Cooldowns (Requires T10 4pc).<br>\
<b>Offensive</b>: Use Blood Tap for extra Icy Touches.',
values: [
{ name: 'Defensive', value: BloodTapPrio.Defensive },
{ name: 'Use as Defensive Cooldown', value: BloodTapPrio.Defensive },
{ name: 'Offensive', value: BloodTapPrio.Offensive },
],
changeEmitter: (player: Player<Spec.SpecTankDeathknight>) => TypedEvent.onAny([player.rotationChangeEmitter, player.talentsChangeEmitter]),
Expand Down
Loading