Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Blood DK Legacy Rotation Opener Usage of Blood Tap with new 4pc cooldown consideration #4043

Merged
merged 2 commits into from
Nov 14, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Configure Blood DK Normal and Threat Openers to conditionally skip us…
…ing Blood Tap and the subsequent Icy Touch enabled by it.

If the DK has the T10 4pc bonus enabled and does not schedule the first Blood Tap usage outside the time the opener uses Blood Tap + the Blood Tap Cooldown, the noted spells will not be used in either opener scenario.

This change comes with a caveat of potentially delaying scheduled Blood Tap casts if the opener Blood Tap is delayed due to ability misses.
cyzin committed Nov 13, 2023
commit 5cb836fcca3340eeed061c9dc8b3a7cbef6d3510
65 changes: 65 additions & 0 deletions sim/deathknight/tank/openers.go
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
package tank

import (
"github.com/wowsims/wotlk/sim/core/proto"
"slices"
"time"

"github.com/wowsims/wotlk/sim/core"
"github.com/wowsims/wotlk/sim/deathknight"
)

const threatOpenerCastsBeforeBloodTap = 2
const normalOpenerCastsBeforeBloodTap = 3

func (dk *TankDeathknight) TankRA_BloodSpell(sim *core.Simulation, target *core.Unit, s *deathknight.Sequence) time.Duration {
casted := dk.BloodSpell.Cast(sim, target)
advance := dk.LastOutcome.Matches(core.OutcomeLanded)
@@ -33,7 +38,38 @@ func (dk *TankDeathknight) TankRA_IT(sim *core.Simulation, target *core.Unit, s
return -1
}

func shouldUseBloodTapInOpener(dk *TankDeathknight) bool {
bloodTapDefensiveCd := dk.GetMajorCooldown(dk.BloodTap.ActionID)
if bloodTapDefensiveCd != nil {
timings := bloodTapDefensiveCd.GetTimings()
slices.Sort(timings)
if len(timings) == 0 ||
(len(timings) > 0 && timings[0] <
dk.BloodTap.CD.Duration+getPlannedOpenerBloodTapUsageTime(dk)) {
return false
} else {
return true
}
}
return true
}

func getPlannedOpenerBloodTapUsageTime(dk *TankDeathknight) time.Duration {
if dk.Rotation.Opener == proto.TankDeathknight_Rotation_Threat {
return threatOpenerCastsBeforeBloodTap * core.GCDDefault
}
return normalOpenerCastsBeforeBloodTap * core.GCDDefault
}

func (dk *TankDeathknight) setupTankRegularERWOpener() {
if shouldUseBloodTapInOpener(dk) {
dk.setupTankRegularERWOpenerWithBloodTap()
} else {
dk.setupTankRegularERWOpenerWithoutBloodTap()
}
}

func (dk *TankDeathknight) setupTankRegularERWOpenerWithBloodTap() {
dk.RotationSequence.
NewAction(dk.TankRA_IT).
NewAction(dk.RotationActionCallback_PS).
@@ -50,7 +86,30 @@ func (dk *TankDeathknight) setupTankRegularERWOpener() {
NewAction(dk.TankRA_FuSpell)
}

func (dk *TankDeathknight) setupTankRegularERWOpenerWithoutBloodTap() {
dk.RotationSequence.
NewAction(dk.TankRA_IT).
NewAction(dk.RotationActionCallback_PS).
NewAction(dk.TankRA_FuSpell).
NewAction(dk.TankRA_BloodSpell).
NewAction(dk.RotationActionCallback_ERW).
NewAction(dk.RotationActionCallback_Pesti).
NewAction(dk.TankRA_IT).
NewAction(dk.TankRA_IT).
NewAction(dk.TankRA_IT).
NewAction(dk.RotationActionCallback_RD).
NewAction(dk.TankRA_FuSpell)
}

func (dk *TankDeathknight) setupTankThreatERWOpener() {
if shouldUseBloodTapInOpener(dk) {
dk.setupTankThreatERWOpenerWithBloodTap()
} else {
dk.setupTankThreatERWOpenerWithoutBloodTap()
}
}

func (dk *TankDeathknight) setupTankThreatERWOpenerWithBloodTap() {
dk.RotationSequence.
NewAction(dk.TankRA_IT).
NewAction(dk.TankRA_IT).
@@ -63,3 +122,9 @@ func (dk *TankDeathknight) setupTankThreatERWOpener() {
NewAction(dk.RotationActionCallback_PS).
NewAction(dk.TankRA_BloodSpell)
}

// If maintaining GCD parity is desired, the threat opener without BT should cast DS with
// the GCD previously allocated to the Blood Tapped IT before using ERW
func (dk *TankDeathknight) setupTankThreatERWOpenerWithoutBloodTap() {
dk.setupTankRegularERWOpenerWithoutBloodTap()
}