Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional SM proc chances #4046

Merged
merged 1 commit into from
Nov 15, 2023
+28 −20
Merged

add additional SM proc chances #4046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions sim/deathknight/diseases.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,17 @@ func (dk *Deathknight) registerBloodPlague() {
// Tier9 4Piece
canCrit := dk.HasSetBonus(ItemSetThassariansBattlegear, 4)

// SM can proc off blood plague application
bloodPlagueApplicationSpell := dk.RegisterSpell(core.SpellConfig{
ActionID: core.ActionID{SpellID: 55078}.WithTag(1),
SpellSchool: core.SpellSchoolShadow,
ProcMask: core.ProcMaskProc,
Flags: core.SpellFlagNoLogs | core.SpellFlagNoMetrics,
ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) {
dk.BloodPlagueSpell.Dot(target).Apply(sim)
},
})

dk.BloodPlagueSpell = dk.RegisterSpell(core.SpellConfig{
ActionID: core.ActionID{SpellID: 55078},
SpellSchool: core.SpellSchoolShadow,
Expand Down Expand Up @@ -170,8 +181,7 @@ func (dk *Deathknight) registerBloodPlague() {
},

ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) {
dot := spell.Dot(target)
dot.Apply(sim)
bloodPlagueApplicationSpell.Cast(sim, target)
},
})
dk.BloodPlagueExtended = make([]int, dk.Env.GetNumTargets())
Expand Down
8 changes: 4 additions & 4 deletions sim/deathknight/dps/TestFrost.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,15 +252,15 @@ dps_results: {
dps_results: {
key: "TestFrost-AllItems-DislodgedForeignObject-50348"
value: {
dps: 11054.42214
tps: 6470.50132
dps: 11054.58588
tps: 6470.59956
}
}
dps_results: {
key: "TestFrost-AllItems-DislodgedForeignObject-50353"
value: {
dps: 11002.10987
tps: 6438.46412
dps: 11001.03092
tps: 6437.82133
}
}
dps_results: {
Expand Down
8 changes: 4 additions & 4 deletions sim/deathknight/dps/TestFrostUH.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,15 +252,15 @@ dps_results: {
dps_results: {
key: "TestFrostUH-AllItems-DislodgedForeignObject-50348"
value: {
dps: 11161.39555
tps: 7940.5934
dps: 11179.30689
tps: 7954.12011
}
}
dps_results: {
key: "TestFrostUH-AllItems-DislodgedForeignObject-50353"
value: {
dps: 11092.40836
tps: 7894.83816
dps: 11092.15512
tps: 7894.5297
}
}
dps_results: {
Expand Down
8 changes: 4 additions & 4 deletions sim/deathknight/dps/TestUnholy.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,16 +278,16 @@ dps_results: {
dps_results: {
key: "TestUnholy-AllItems-DislodgedForeignObject-50348"
value: {
dps: 11799.1826
tps: 7724.64572
dps: 11798.98234
tps: 7724.62368
hps: 319.74369
}
}
dps_results: {
key: "TestUnholy-AllItems-DislodgedForeignObject-50353"
value: {
dps: 11803.67413
tps: 7738.22348
dps: 11803.88112
tps: 7738.28514
hps: 318.90115
}
}
Expand Down
2 changes: 1 addition & 1 deletion sim/deathknight/scourge_strike.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func (dk *Deathknight) registerScourgeStrikeShadowDamageSpell() *core.Spell {
return dk.Unit.RegisterSpell(core.SpellConfig{
ActionID: ScourgeStrikeActionID.WithTag(2),
SpellSchool: core.SpellSchoolShadow,
ProcMask: core.ProcMaskSpellDamage,
ProcMask: core.ProcMaskSpellDamage | core.ProcMaskProc,
Flags: core.SpellFlagMeleeMetrics | core.SpellFlagIgnoreAttackerModifiers,

DamageMultiplier: 1,
Expand Down
4 changes: 1 addition & 3 deletions sim/deathknight/talents_unholy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,10 @@ func (dk *Deathknight) applyBloodCakedBlade() {
}

func (dk *Deathknight) bloodCakedBladeHit(isMh bool) *core.Spell {
procMask := core.ProcMaskProc

return dk.Unit.RegisterSpell(core.SpellConfig{
ActionID: core.ActionID{SpellID: 50463}.WithTag(core.TernaryInt32(isMh, 1, 2)),
SpellSchool: core.SpellSchoolPhysical,
ProcMask: procMask,
ProcMask: core.ProcMaskProc,
Flags: core.SpellFlagNoOnCastComplete | core.SpellFlagMeleeMetrics,

DamageMultiplier: 1 *
Expand Down
2 changes: 1 addition & 1 deletion sim/rogue/TestAssassination.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ character_stats_results: {
final_stats: 221
final_stats: 0
final_stats: 5504.84
final_stats: 469.94994
final_stats: 469.94995
final_stats: 2072.9756
final_stats: 221
final_stats: 94
Expand Down
2 changes: 1 addition & 1 deletion sim/rogue/TestCombat.results
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ character_stats_results: {
final_stats: 264
final_stats: 0
final_stats: 5996.3904
final_stats: 418.94994
final_stats: 418.94995
final_stats: 2218.9399
final_stats: 264
final_stats: 94
Expand Down
Loading