Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor updates for rotation #4048

Merged
merged 1 commit into from
Nov 16, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions sim/priest/shadow/rotation.go
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ func (spriest *ShadowPriest) chooseSpellIdeal(sim *core.Simulation) (*core.Spell
bestIdx = swpIdx
}
// Snap shot BL on DP
if overwriteDPS2-currDPS2 > 2000 && bestIdx != vtIdx { //Seems to be a dps loss to overwrite a DP to snap shot
if overwriteDPS2-currDPS2 > 2500 && bestIdx != vtIdx { //Seems to be a dps loss to overwrite a DP to snap shot
bestIdx = dpIdx
currentWait = 0
}
Expand Down Expand Up @@ -634,7 +634,7 @@ func (spriest *ShadowPriest) chooseSpellIdeal(sim *core.Simulation) (*core.Spell
if chosenMfs == 1 {
numTicks = 1 // determiend above that it's more dps to add MF1, need if it's not better to enter ideal rotation instead
} else if (castMf2 == 1 && spriest.DevouringPlague.CurDot().IsActive() && spriest.VampiricTouch.CurDot().IsActive()) || (timeUntilBLStarts < (time.Duration(3)*tickLength).Seconds() && timeUntilBLStarts > 0.2) {
if spriest.MindFlayTickDuration()*3 < gcd {
if float64(spriest.MindFlayTickDuration().Seconds()*3) < float64(gcd.Seconds()*1.3) {
numTicks = 3
} else {
numTicks = 2
Expand Down Expand Up @@ -743,7 +743,7 @@ func (spriest *ShadowPriest) IdealMindflayRotation(sim *core.Simulation, gcd tim

AlmostAnotherTick := numTicks_Base - numTicks_floored

if AlmostAnotherTick >= 0.3 {
if AlmostAnotherTick >= 0.25 {
numTicks += 1
}

Expand Down Expand Up @@ -842,7 +842,7 @@ func (spriest *ShadowPriest) IdealMindflayRotation(sim *core.Simulation, gcd tim
}
AlmostAnotherTick := numTicks_Base - numTicks_floored

if AlmostAnotherTick >= 0.3 {
if AlmostAnotherTick >= 0.2 {
numTicks += 1
}

Expand All @@ -860,7 +860,7 @@ func (spriest *ShadowPriest) IdealMindflayRotation(sim *core.Simulation, gcd tim
max(0, spriest.AllCDs[3]-mfTime),
0,
}
if deltaTime.Seconds() < -0.33 {
if deltaTime.Seconds() < -1 {
numTicks -= 1
cdDiffs[bestIdx] += tickLength
}
Expand Down
Loading