Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement item swapping in APL #4103

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Implement item swapping in APL #4103

merged 1 commit into from
Dec 23, 2023

Conversation

jimmyt857
Copy link
Contributor

Implements #4082.

A few notes on this PR:

  • All existing ItemSwap options (DK DPS, Enhance, and Warlock) are deprecated and replaced with new fields on the Player proto.
  • UI changes include conversion logic for backwards compatibility.
  • Legacy rotation logic should be preserved.
  • sim.ts files in the UI have a new option to specify which item swap slots are supported. This means that even though APL is generically supporting item swaps now, they are still not enabled for any new classes/specs.
  • Refactor the UI ItemSwapGear class to correctly be immutable.

@jimmyt857 jimmyt857 merged commit 4ce80f8 into master Dec 23, 2023
2 checks passed
@jimmyt857 jimmyt857 deleted the apl branch December 23, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant