Closes #40 Update CDN cname

[remyperona]

Description

Fixes #40

Automatically updates the current CDN cname on update of the plugin and display an info notice to inform the user

Type of change

• Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Update the plugin

Technical description

Documentation

Explain how this code works. Diagrams & drawings are welcome.

Mandatory Checklist

Code validation

• I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I implemented built-in tests to cover the new/changed code.

Code style

• I wrote a self-explanatory code about what it does.
• I protected entry points against unexpected inputs.
• I did not introduce unnecessary complexity.
• Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Additional Checks

• I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

[remyperona]

Updated the code to take care of fresh install and prevent the notice from displaying.

[hanna-meda]

@remyperona, retested on this site where we have rocketcdn staging linked to it, so we can actually see the CNAME updated. There are a few points that still need to be addressed:

1. The Notification will still be present on fresh installs but not immediately.
   It appears after validating API key.
2. The Notification cannot be dismissed.
   Clicking on "X" button doesn't trigger any action.
3. The old name is missing from the notification:

@wp-media/product, I have a question regarding the following scenario:

1. RocketCDN version <=1.0.6 installed & activated, but the API key hasn’t been validated.
2. The user updates to version 1.0.7 => In this case, should we expect the notification to appear? Since the user hasn’t provided their API key yet, we wouldn’t know it.

[piotrbak]

@hanna-meda

1. RocketCDN version <=1.0.6 installed & activated, but the API key hasn’t been validated.
2. The user updates to version 1.0.7 => In this case, should we expect the notification to appear? Since the user hasn’t provided their API key yet, we wouldn’t know it.

That's kind of edgy. What's the current state?

[hanna-meda]

That's kind of edgy. What's the current state?

@piotrbak the notification will *NOT be there.

[piotrbak]

@hanna-meda Do you have a screenshot of notification from this scenario? Since the API is not there, we'll not display the URLs?

[hanna-meda]

@piotrbak, Correction: the notification will not be there in this case. But it will be there after validating key, in which case we will have empty for from (which is a general issue even when we did validate key in previous version, same as in above issue no. 3 ):

[piotrbak]

@hanna-meda That sounds good if the issue 3 is fixed.

[remyperona]

All reported issues should be fixed now. I tested directly the notification dismiss issue on the test site, found the issue and now it's all good.

[hanna-meda]

Thank you, @remyperona.
I can confirm all issues are fixed except point 3. The old name is missing from the notification

• Testing on mega (site linked to staging rocketCDN website where the namedelivery update is in place), the notification banner cannot be triggered anymore:
  link to video
• Testing on newer (site linked to rocketCDN production), I can see the notification but with old name missing:

P.S. Left API key validated on mega now. But, if not, for everyone who needs it, the API key can be found in BW by name `RocketCDN API Key to use on mega site`

[remyperona]

Ok I finally found the issue for this point, it should be good now! I tested on the newer site, and got the notification with both old and new CDN URL filled (since it's using production API, it ends up being the same value for now).

[hanna-meda]

Related Test Results Report:
testrail-report-662.pdf