-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor gulpfile to be more dynamic #6625
Conversation
…called dynamically, also added a configuration file to make it easier to see list of tasks for each module
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more Footnotes
|
Should this PR be made a real PR and not a draft? As I see it's "Ready for review". Thanks! |
|
Done |
Could you add somewhere (either in the main gulp file, or the readme) The list of all gulp commands, and what it does? That would be helpful for everyone old and new as a quick reference instead of having to inside the code. |
Good idea, doing that now. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more Footnotes
|
Closes #6601
Here I restructured the the gulp tasks and split main tasks between css and js tasks and has a config file to define the gulp tasks and the corresponding method to do that task.
List of gulp tasks that can be called directly using gulp cli command are mentioned here:
https://github.com/wp-media/wp-rocket/blob/a8e8fead41e3103511a467bffaf634cdf3f75a9c/src/js/gulp/gulpconfig.js
Also I added main big scripts inside package.json
Q: Do we need to be backward compatible with the old gulp tasks that I removed in this PR?