Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLAG-997] GADM country list #4891

Open
wants to merge 20 commits into
base: epic/gadm
Choose a base branch
from

Conversation

willian-viana
Copy link
Collaborator

Overview

Brief description of what this PR does, and why it is needed.

Demo

If applicable: screenshots, gifs, etc.

Notes

If applicable: ancilary topics, caveats, alternative strategies that didn't work out, etc.

Testing

  • Include any steps to verify the features this PR introduces.
  • If this fixes a bug, include bug reproduction steps.

@willian-viana willian-viana self-assigned this Nov 25, 2024
@willian-viana willian-viana force-pushed the epic/gadm branch 2 times, most recently from 4d0b54d to f6a9065 Compare November 25, 2024 14:58
@willian-viana willian-viana force-pushed the feat/GADM-country-list-FLAG-997 branch 3 times, most recently from dad9bf0 to eb3e427 Compare November 25, 2024 15:06
@willian-viana willian-viana force-pushed the feat/GADM-country-list-FLAG-997 branch from eb3e427 to 2223e1c Compare November 25, 2024 17:02
@willian-viana willian-viana marked this pull request as ready for review December 18, 2024 18:17
@willian-viana willian-viana force-pushed the feat/GADM-country-list-FLAG-997 branch from 2223e1c to 6a8efa2 Compare December 18, 2024 18:18
@willian-viana willian-viana changed the title [FLAG-997] GADM coutry list [FLAG-997] GADM country list Dec 19, 2024
@@ -1,44 +1,71 @@
import lowerCase from 'lodash/lowerCase';
import startCase from 'lodash/startCase';
import { cartoRequest } from 'utils/request';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

farewell cartoReuest 👍

@@ -1,9 +1,9 @@
export const getGadm36Id = (country, region, subRegion) =>
export const getGadmId = (country, region, subRegion) =>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea to rename it 👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Well done!

Copy link

@gtempus gtempus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the improvements and additional tests added in this PR, Will. Well done! I do have a suggested refactor for location.js if you agree.

@willian-viana willian-viana force-pushed the feat/GADM-country-list-FLAG-997 branch from 5c4904c to 375936d Compare January 27, 2025 19:04
Copy link

@gtempus gtempus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @willian-viana! Well done. 🤓 🎨

@willian-viana willian-viana force-pushed the feat/GADM-country-list-FLAG-997 branch from 022517b to 86c76b5 Compare January 30, 2025 15:52
@willian-viana willian-viana force-pushed the feat/GADM-country-list-FLAG-997 branch from bb349eb to d469aad Compare February 4, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants