-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLAG-997] GADM country list #4891
base: epic/gadm
Are you sure you want to change the base?
Conversation
4d0b54d
to
f6a9065
Compare
dad9bf0
to
eb3e427
Compare
27728a3
to
9d96124
Compare
eb3e427
to
2223e1c
Compare
2223e1c
to
6a8efa2
Compare
9d96124
to
d81eea8
Compare
d81eea8
to
4d705c8
Compare
4d705c8
to
6283af5
Compare
f860c72
to
2175cad
Compare
6e81f81
to
ee40c05
Compare
6283af5
to
89cc0a9
Compare
@@ -1,44 +1,71 @@ | |||
import lowerCase from 'lodash/lowerCase'; | |||
import startCase from 'lodash/startCase'; | |||
import { cartoRequest } from 'utils/request'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
farewell cartoReuest 👍
@@ -1,9 +1,9 @@ | |||
export const getGadm36Id = (country, region, subRegion) => | |||
export const getGadmId = (country, region, subRegion) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great idea to rename it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the improvements and additional tests added in this PR, Will. Well done! I do have a suggested refactor for location.js
if you agree.
5c4904c
to
375936d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @willian-viana! Well done. 🤓 🎨
022517b
to
86c76b5
Compare
bb349eb
to
d469aad
Compare
Overview
Brief description of what this PR does, and why it is needed.
Demo
If applicable: screenshots, gifs, etc.
Notes
If applicable: ancilary topics, caveats, alternative strategies that didn't work out, etc.
Testing