Improve TOTP authenticator to skip locking account when account lock is disabled #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
|
PR builder completed |
PasinduYeshan
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When account locking is disabled, there is no governance connector config whether account lock on failed login is enabled or disabled (The config exists only if enabled). Due to that existing logic fails to detect the account locking is disabled.
Under above mentioned state, there can be scenarios TOTP authenticator is being used as second factor with account lock happens even it was not configured by the Administrator.
The Administrator must intentionally disable account locking on failed attempts for the situation mentioned above. Correcting the buggy behavior can be done without requiring any notification.
Related Issues