Utilize APIProvider to retrieve all APIs in admin REST API
#12679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `APIAdmin` content search implementation for APIs retrieval, `searchPaginatedApis` to `APIProvider` APIs search implementation `searchPaginatedAPIs`
nimsara66
requested review from
tharindu1st,
AnuGayan,
chamilaadhi,
Arshardh,
dushaniw and
tgtshanika
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: wso2/api-manager#3241
Approach
The current implementation of the
getAllAPIsmethod in the admin REST API relies on thesearchPaginatedApisfunctionality fromAPIAdmin. This performs a content-based search that retrieves all APIs, API Products, and Documents, subject to a predefined constraint on the number of search results. As outlined in the issue, this approach may result in an empty API result set if the returned list only contains API Products and Documents.This pr addresses the limitation by leveraging the
APIProvider'ssearchPaginatedAPIsmethod, which directly retrieves all APIs fromAPIPersistence. This change ensures that the API results are not impacted by the presence of other entities such as API Products and Documents.