Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new configuration to indefinitely lock the user until admin unlock #6997

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

sandushi
Copy link
Contributor

@sandushi sandushi commented Oct 16, 2024

Purpose

  • Support the feature of indefinitely lock the user account until the admin unlocks the account when initial lock duration to 0.
  • This changes support this feature with a better UX, other that set the initial lock duration to 0.
  • With the new console UI, value 0 is not allowed as the initial lock duration
  • So, with these changes , introduced two options as below
    • Lock account for specified duration --> Account lock time and increment factor can be configured.
    • Lock account indefinitely --> Account is locked until admin unlocks
  • We can select one option from above two, and the duration time is set according to the selected option.
  • The Note is also updated according to the selected option.
  • If select the Lock account indefinitely option, the account lock time and increment factor fields are hidden.

When disabling the feature

Screenshot from 2025-01-18 00-51-48

When enabling the feature

  1. When select option 1 --> default selected option is this.

Screenshot from 2025-01-18 00-52-39

  1. When select option 2

Screenshot from 2025-01-18 00-53-09

Related Issues

wso2/product-is#21219

Related PRs

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.04%. Comparing base (9ecf97c) to head (d956d20).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6997   +/-   ##
=======================================
  Coverage   36.04%   36.04%           
=======================================
  Files          42       42           
  Lines         899      899           
  Branches      205      222   +17     
=======================================
  Hits          324      324           
+ Misses        575      529   -46     
- Partials        0       46   +46     
Flag Coverage Δ
@wso2is/core 36.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

@DilshanSenarath
Copy link
Contributor

Don't we need to disable the Account lock duration increment factor as well?

@pavinduLakshan pavinduLakshan changed the title Add new configuration to indefinitely lock the user util admin unlock Add new configuration to indefinitely lock the user until admin unlock Jan 18, 2025
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants