UI for the XACML Connector #7313

JeethJJ · 2025-01-16T12:50:57Z

Purpose

As a part of the effort to make XACML a connector, we are introducing a new UI for the react console.

Derived from : [WIP] UI for the XACML Connector #7301

Related Issues

N/A

Related PRs

N/A

Checklist

e2e cypress tests locally verified. (for internal contributers)
Manual test round performed and verified.
UX/UI review done on the final implementation.
Documentation provided. (Add links if there are any)
Relevant backend changes deployed and verified
Unit tests provided. (Add links if there are any)
Integration tests provided. (Add links if there are any)

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines
Ran FindSecurityBugs plugin and verified report
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets

This reverts commit 64538f8.

…tion-feature

codecov · 2025-01-16T15:02:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.04%. Comparing base (1463149) to head (563925f).
Report is 88 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7313   +/-   ##
=======================================
  Coverage   36.04%   36.04%           
=======================================
  Files          42       42           
  Lines         899      899           
  Branches      222      217    -5     
=======================================
  Hits          324      324           
+ Misses        575      529   -46     
- Partials        0       46   +46

Flag	Coverage Δ
@wso2is/core	`36.04% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

pavinduLakshan · 2025-01-17T03:39:46Z

Let's add the changeset, and a screencast/screenshot of the UI.

features/admin.policy-administration.v1/package.json

features/admin.policy-administration.v1/pages/edit-policy.scss

features/admin.policy-administration.v1/pages/edit-policy.tsx

.changeset/witty-ants-allow.md

apps/console/src/public/deployment.config.json

Co-authored-by: Pavindu Lakshan <[email protected]>

features/admin.policy-administration.v1/CHANGELOG.md

features/admin.policy-administration.v1/api/entitlement-policies.ts

features/admin.policy-administration.v1/api/updateAlgorithm.ts

features/admin.policy-administration.v1/api/useGetAlgorithm.ts

features/admin.policy-administration.v1/api/useGetPolicies.ts

modules/react-components/src/components/file-picker/file-picker.tsx

modules/i18n/src/translations/en-US/portals/policy-administration.ts

modules/i18n/src/models/namespaces/policy-administration-ns.ts

…es.ts Co-authored-by: Pavindu Lakshan <[email protected]>

Co-authored-by: Pavindu Lakshan <[email protected]>

…nistration-page-layout.tsx Co-authored-by: Pavindu Lakshan <[email protected]>

…nistration-page-layout.tsx

…or/policy-editor.scss

…nistration-page-layout.tsx Co-authored-by: Pavindu Lakshan <[email protected]>

…or/policy-editor.tsx Co-authored-by: Pavindu Lakshan <[email protected]>

...s/admin.policy-administration.v1/components/edit-policy-algorithm/edit-policy-algorithm.scss

pavinduLakshan · 2025-01-17T07:07:26Z

features/admin.policy-administration.v1/components/edit-policy-algorithm/index.ts

Let's get rid of index files. we are moving away from using index files.

https://josselinbuils.dev/blog/stop-using-index-files

features/admin.policy-administration.v1/rollup.config.cjs

features/admin.policy-administration.v1/types/imports.d.ts

pavinduLakshan · 2025-01-17T07:11:11Z

features/admin.policy-administration.v1/utils/policy-algorithms.ts

+        value: 1
+    },
+    {
+        description: "The permit overrides combining algorithm is intended for those cases where a permit " +


Let's use i18n for string literals

features/admin.policy-administration.v1/components/policy-list.tsx

pavinduLakshan · 2025-01-17T07:18:39Z

features/admin.policy-administration.v1/components/policy-list.scss

@@ -0,0 +1,5 @@
+.policy-inactive-list{


Add license header

features/admin.policy-administration.v1/components/wizard/new-policy-wizard.scss

…-algorithm/edit-policy-algorithm.scss Co-authored-by: Pavindu Lakshan <[email protected]>

Co-authored-by: Pavindu Lakshan <[email protected]>

….tsx Co-authored-by: Pavindu Lakshan <[email protected]>

…policy-wizard.scss Co-authored-by: Pavindu Lakshan <[email protected]>

wso2-jenkins-bot · 2025-01-17T07:50:19Z

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

JeethJJ · 2025-01-17T07:50:34Z

Rest of the comments will be addressed by @adibmbrk during improvements.

brionmario · 2025-01-17T08:05:08Z

Lets address the lint issues and the existing PR comments in a followup PR.

+1 to merge this.

brionmario · 2025-01-17T09:26:23Z

apps/console/src/configs/routes.tsx

+                icon: getSidePanelIcons().policyAdministration
+            },
+            id: "policyAdministration",
+            name: "Policy Administration",


Add i18n keys

brionmario · 2025-01-17T09:27:56Z

apps/console/src/public/deployment.config.json

@@ -891,6 +891,7 @@
                "scopes": {


Check if all the RBAC related configs are added.

J2 Mappings

default.json updates

console ui scopes registered

brionmario · 2025-01-17T09:30:23Z

features/admin.policy-administration.v1/api/use-get-algorithm.ts

+ * @param {boolean} shouldFetch - Flag to determine if the data should be fetched.
+ * @return {RequestResultInterface} Response as a promise.
+ */
+export const useGetAlgorithm = <Data = AlgorithmResponseInterface, Error = RequestErrorInterface>(


Shall we make this a bit more specific.

useGetEntitlementPolicyCombiningAlgorithm

brionmario · 2025-01-17T09:31:45Z

features/admin.policy-administration.v1/components/policy-administration-page-layout.scss

+    padding: 0;
+}
+
+#active-policy-list-container{


Lets not use ids to identify elements.

Suggested change

#active-policy-list-container{

#active-policy-list-container {

brionmario · 2025-01-17T09:32:17Z

features/admin.policy-administration.v1/components/policy-administration-page-layout.tsx

+        }
+
+    }, [ activePolicyArray ]);
+


Remove these extra line breaks in all the files.

Suggested change

adibmbrk and others added 15 commits January 7, 2025 12:16

Add policy administration feature

7591344

Refactor folder structure and add API request configs

9f1579e

Fix edit policy page path params

44a37d2

Revert changes made in script editor panel

d7be5bf

Add update policy use case

44f1b75

Add delete policy use case

768a6f5

Fix typo

0866786

Add create policy

27b68d6

Refactor policy algorithm list

f6c3023

Add API for publishing a policy

89a17df

Refactor the code to resolve ESlint issues

97143ad

Merge upstream/master into policy-administration-feature

64538f8

Revert "Merge upstream/master into policy-administration-feature"

f5e3634

This reverts commit 64538f8.

Merge remote-tracking branch 'upstream/master' into policy-administra…

69e56a9

…tion-feature

Update dnd imports and fix errors

1463149

Add droppable container for active policies.

575fe18

JeethJJ added 2 commits January 17, 2025 09:13

Add changeset

5a5577a

Disable feature.

af80c83

pavinduLakshan reviewed Jan 17, 2025

View reviewed changes

Update .changeset/witty-ants-allow.md

5a8bde3

Co-authored-by: Pavindu Lakshan <[email protected]>

pavinduLakshan reviewed Jan 17, 2025

View reviewed changes

JeethJJ and others added 6 commits January 17, 2025 10:17

Update features/admin.policy-administration.v1/api/entitlement-polici…

1b5a9b1

…es.ts Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/api/entitlement-polici…

7edadd1

…es.ts Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/api/updateAlgorithm.ts

2a8b596

Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/package.json

03effab

Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/pages/edit-policy.scss

bcf981a

Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/pages/edit-policy.scss

109dd35

Co-authored-by: Pavindu Lakshan <[email protected]>

JeethJJ and others added 12 commits January 17, 2025 12:36

Update features/admin.policy-administration.v1/components/policy-admi…

3d6584c

…nistration-page-layout.tsx Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/components/policy-admi…

5a0ea89

…nistration-page-layout.tsx Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/components/policy-admi…

5afa392

…nistration-page-layout.tsx

Update features/admin.policy-administration.v1/components/policy-edit…

8460f31

…or/policy-editor.scss

Update features/admin.policy-administration.v1/components/policy-admi…

d230070

…nistration-page-layout.tsx Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/components/policy-admi…

0011639

…nistration-page-layout.tsx Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/components/policy-admi…

0f09aa3

…nistration-page-layout.tsx Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/components/policy-admi…

f296fb9

…nistration-page-layout.tsx Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/components/policy-admi…

4657800

…nistration-page-layout.tsx Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/components/policy-admi…

46f330e

…nistration-page-layout.tsx Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/components/policy-edit…

be749ce

…or/policy-editor.tsx Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/components/policy-edit…

7789450

…or/policy-editor.tsx Co-authored-by: Pavindu Lakshan <[email protected]>

pavinduLakshan reviewed Jan 17, 2025

View reviewed changes

JeethJJ and others added 7 commits January 17, 2025 13:18

Update features/admin.policy-administration.v1/components/edit-policy…

3d2eb30

…-algorithm/edit-policy-algorithm.scss Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/rollup.config.cjs

faeb2ac

Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/types/imports.d.ts

aa799b7

Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/components/policy-list…

9a4a63b

….tsx Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/components/policy-list…

b08d38b

….tsx Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/components/policy-list…

86610e0

….tsx Co-authored-by: Pavindu Lakshan <[email protected]>

Update features/admin.policy-administration.v1/components/wizard/new-…

563925f

…policy-wizard.scss Co-authored-by: Pavindu Lakshan <[email protected]>

brionmario approved these changes Jan 17, 2025

View reviewed changes

JeethJJ merged commit ba4fe33 into wso2:master Jan 17, 2025
5 of 6 checks passed

brionmario reviewed Jan 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI for the XACML Connector #7313

UI for the XACML Connector #7313

JeethJJ commented Jan 16, 2025

codecov bot commented Jan 16, 2025 •

edited

Loading

pavinduLakshan commented Jan 17, 2025

pavinduLakshan Jan 17, 2025

pavinduLakshan Jan 17, 2025

pavinduLakshan Jan 17, 2025

wso2-jenkins-bot commented Jan 17, 2025

JeethJJ commented Jan 17, 2025

brionmario commented Jan 17, 2025

brionmario Jan 17, 2025

brionmario Jan 17, 2025

brionmario Jan 17, 2025

brionmario Jan 17, 2025

brionmario Jan 17, 2025

	#active-policy-list-container{
	#active-policy-list-container {

UI for the XACML Connector #7313

UI for the XACML Connector #7313

Conversation

JeethJJ commented Jan 16, 2025

Purpose

Related Issues

Related PRs

Checklist

Security checks

codecov bot commented Jan 16, 2025 • edited Loading

Codecov Report

pavinduLakshan commented Jan 17, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wso2-jenkins-bot commented Jan 17, 2025

🦋 Changeset detected

JeethJJ commented Jan 17, 2025

brionmario commented Jan 17, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jan 16, 2025 •

edited

Loading